Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gwells 2190 vue update 2 to 3 #2261

Draft
wants to merge 18 commits into
base: release
Choose a base branch
from
Draft

Conversation

fergmac
Copy link
Contributor

@fergmac fergmac commented Jun 24, 2024

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [GWELLS-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • *Note: Just pushing up changes to transfer working changes back to returned work computer.
  • Vue Compat migration build. To be able to run the application while using Vue 2 dependencies and work through breaking changes.

@fergmac fergmac self-assigned this Jun 24, 2024
@fergmac fergmac closed this Jun 25, 2024
@fergmac fergmac reopened this Jun 25, 2024
const TEST_MATOMO_HOST =
"https://water-matomo-staging.apps.silver.devops.gov.bc.ca/";

const isProduction = () => window.location.href.includes(PRODUCTION_GWELLS_URL); //Does not return true for the production site @https://gwells.apps.silver.devops.gov.bc.ca/gwells

Check failure

Code scanning / CodeQL

Incomplete URL substring sanitization High

'
https://apps.nrs.gov.bc.ca/gwells
' can be anywhere in the URL, and arbitrary hosts may come before or after it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant