Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glance() for brmsfit #146

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Fix glance() for brmsfit #146

merged 2 commits into from
Dec 9, 2023

Conversation

alyst
Copy link

@alyst alyst commented Dec 8, 2023

  • Fix calculating the number of samples
  • Don't require rstanarm for sigma statistics

Alexey Stukalov added 2 commits December 8, 2023 12:08
@alyst
Copy link
Author

alyst commented Dec 8, 2023

I think the failures are not related to this PR.
I don't see glance.brmsfit-related errors in the logs.
Cholesky matrix errors are likely from incompatible R/Matrix versions.

@bbolker
Copy link
Owner

bbolker commented Dec 8, 2023

I agree, I'm trying to fix this via lme4/lme4#756 (comment)

@bbolker bbolker merged commit 62fa7d8 into bbolker:main Dec 9, 2023
1 check failed
@bbolker
Copy link
Owner

bbolker commented Dec 9, 2023

Thanks. I do now get examples for the brmsfit tidiers taking slightly over 5 seconds on GH actions, but hopefully this won't be a problem ...

@alyst alyst deleted the fix_brmsit_glance branch December 10, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alyst @bbolker