-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore ways to have more package metadata providers. #59
Draft
aiuto
wants to merge
12
commits into
bazelbuild:main
Choose a base branch
from
aiuto:bazelcon
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 14, 2022
-
Explore ways to have more package metadata providers.
Licenses are still special because they need to go down to the license_kind, but other metadata (self-contained) providers can be gathered generically. This PR has two parallel implementations so we can explore the ramifactions of each. The early attempt was to make PackageInfo a first class element, equal to LicensesInfo in the way we recursively gather it. The problem with that approach is that it requires you to scale licenses_core.bzl with each new type. A different approach is to have a generic TransitiveMetadataInfo collector that can hold many different types of provider in it, as long as they all obey the same protocol for identifying their type. We pass a provider list to gather_licenses_info_common() to select what to include. This way, a user adding a private metadata type only needs to add a new write-json capability for their custom provider. That is still a little ugly, but at least we can share gather_licenses_info_common().
Configuration menu - View commit details
-
Copy full SHA for 0565925 - Browse repository at this point
Copy the full SHA 0565925View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbff1f8 - Browse repository at this point
Copy the full SHA bbff1f8View commit details
Commits on Nov 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a1167c0 - Browse repository at this point
Copy the full SHA a1167c0View commit details
Commits on Dec 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f8fdd64 - Browse repository at this point
Copy the full SHA f8fdd64View commit details
Commits on Dec 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4a60c99 - Browse repository at this point
Copy the full SHA 4a60c99View commit details
Commits on Dec 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4f0d93f - Browse repository at this point
Copy the full SHA 4f0d93fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0198dd6 - Browse repository at this point
Copy the full SHA 0198dd6View commit details
Commits on Jan 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 554d7b4 - Browse repository at this point
Copy the full SHA 554d7b4View commit details
Commits on Feb 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 846d043 - Browse repository at this point
Copy the full SHA 846d043View commit details
Commits on Feb 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2d3fd73 - Browse repository at this point
Copy the full SHA 2d3fd73View commit details
Commits on Feb 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6111aa4 - Browse repository at this point
Copy the full SHA 6111aa4View commit details
Commits on Feb 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5567e23 - Browse repository at this point
Copy the full SHA 5567e23View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.