BcDatabaseService::updateSequence() ユニットテスト調整 (#3900)

Co-authored-by: Đỗ Văn Hùng <[email protected]>
baserproject · Oct 16, 2024 · 96fe6a5 · 96fe6a5
1 parent 360cd14
commit 96fe6a5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/plugins/baser-core/src/Service/BcDatabaseService.php b/plugins/baser-core/src/Service/BcDatabaseService.php
@@ -663,14 +663,15 @@ public function initSystemData($options = []): bool
      * データベースシーケンスをアップデートする
      * @checked
      * @noTodo
+     * @unitTest
      */
     public function updateSequence()
     {
         $db = ConnectionManager::get('default');
-        if($db->config()['driver'] !== Postgres::class) return true;
+        if ($db->config()['driver'] !== Postgres::class) return true;
         $tables = $db->getSchemaCollection()->listTables();
         $result = true;
-        foreach($tables as $table) {
+        foreach ($tables as $table) {
             if (preg_match('/(^|_)phinxlog$/', $table)) continue;
             $sql = 'select setval(\'' . $this->getSequence($table) . '\', (select max(id) from ' . $table . '));';
             if (!$db->execute($sql)) $result = false;

diff --git a/plugins/baser-core/tests/TestCase/Service/BcDatabaseServiceTest.php b/plugins/baser-core/tests/TestCase/Service/BcDatabaseServiceTest.php
@@ -34,6 +34,7 @@
 use Cake\Database\Driver\Mysql;
 use Cake\Database\Driver\Postgres;
 use Cake\Database\Driver\Sqlite;
+use Cake\Datasource\ConnectionManager;
 use Cake\ORM\TableRegistry;
 use Cake\TestSuite\IntegrationTestTrait;
 use Cake\Utility\Inflector;
@@ -1036,4 +1037,14 @@ public function test_columnExists()
         // drop table
         $this->BcDatabaseService->dropTable($table);
     }
+
+    /**
+     * test updateSequence
+     * @TODO PostgreSQLのテスト
+     */
+    public function testUpdateSequence()
+    {
+        // デフォルトdriver：MYSQL
+        $this->assertTrue($this->BcDatabaseService->updateSequence());
+    }
 }