-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Traefik to run without publishing port #368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a few lines in the docs about?
1: that this exists now
2: how to use it with an additional traefik/nginx rev proxy (or just a link to a guide) and a usecase (i.e. "if you want to host 2 apps on a same machine use this + a separate traefik/nginx")
Sure, in this case are the docs the README? Happy to add it to the site repo too but I assumed that would happen after this was merged (or at least approved)? |
Can you rebase? Looks good to me. |
Doc change needs to happen against basecamp/kamal-site repo. |
Adds the `publish` option which, if set to false, does not pass `--publish` to `docker run` when starting Traefik. This is useful when running Traefik behind a reverse proxy, for example.
Change introduced in basecamp/kamal#368
I've rebased and added documentation to the site repo basecamp/kamal-site#17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work and a nice option - we run multiple application containers on different docker networks behind a broader proxy and have no need to bind to the host - this avoids port shuffling.
Adds the
publish
option which, if set to false, does not pass--publish
todocker run
when starting Traefik. This is useful when running Traefik behind a reverse proxy, for example.Example deploy.yml:
If not specified or set to true, the default or specified port will be used as per current behaviour.