add more logging and remove dead code

base-org · Sep 17, 2024 · ef0cfd1 · ef0cfd1
1 parent 60ccbca
commit ef0cfd1
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 225 deletions.
diff --git a/apps/web/package.json b/apps/web/package.json
@@ -21,7 +21,6 @@
     "@headlessui/react": "^1.7.19",
     "@heroicons/react": "^2.1.3",
     "@lottiefiles/dotlottie-react": "^0.8.10",
-    "@noble/ed25519": "^2.1.0",
     "@radix-ui/react-accordion": "^1.2.0",
     "@radix-ui/react-popover": "^1.1.1",
     "@radix-ui/react-tooltip": "^1.1.2",

diff --git a/apps/web/src/components/Basenames/UsernameProfileSectionFrames/Context.tsx b/apps/web/src/components/Basenames/UsernameProfileSectionFrames/Context.tsx
@@ -162,8 +162,6 @@ export function FramesProvider({ children }: FramesProviderProps) {
     async ({ signatureData }) => {
       if (!address) {
         openConnectModal?.();
-        console.info('Opened connect modal because the account address is not set');
-
         return null;
       }
 
@@ -189,12 +187,12 @@ export function FramesProvider({ children }: FramesProviderProps) {
           setFrameInteractionError('Error signing data');
         }
 
-        console.error(error);
+        logError(error, 'failed to sign frame data');
 
         return null;
       }
     },
-    [address, openConnectModal, currentChainId, config],
+    [address, openConnectModal, currentChainId, config, logError],
   );
 
   const { writeContractAsync, isPending: pendingFrameChange } = useWriteContract();
@@ -222,20 +220,21 @@ export function FramesProvider({ children }: FramesProviderProps) {
           args: [nameHash, UsernameTextRecordKeys.Frames, frameUrl.trim()],
           functionName: 'setText',
         });
-        refetchExistingTextRecords().catch(console.warn);
+        refetchExistingTextRecords().catch((e) => logError(e, 'failed to refetch text records'));
         return result;
       }
       return doTransaction();
     },
     [
       address,
+      currentChainId,
       profileUsername,
-      basenameChain,
       writeContractAsync,
-      config,
-      currentChainId,
-      openConnectModal,
+      basenameChain.id,
       refetchExistingTextRecords,
+      openConnectModal,
+      config,
+      logError,
     ],
   );
 

diff --git a/apps/web/src/hooks/useStorage.ts b/apps/web/src/hooks/useStorage.ts
diff --git a/apps/web/src/utils/farcaster/crypto.ts b/apps/web/src/utils/farcaster/crypto.ts
diff --git a/apps/web/src/utils/farcaster/identityPoller.ts b/apps/web/src/utils/farcaster/identityPoller.ts
diff --git a/yarn.lock b/yarn.lock
@@ -362,7 +362,6 @@ __metadata:
     "@headlessui/react": ^1.7.19
     "@heroicons/react": ^2.1.3
     "@lottiefiles/dotlottie-react": ^0.8.10
-    "@noble/ed25519": ^2.1.0
     "@radix-ui/react-accordion": ^1.2.0
     "@radix-ui/react-popover": ^1.1.1
     "@radix-ui/react-tooltip": ^1.1.2
@@ -5492,7 +5491,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@noble/ed25519@npm:^2.0.0, @noble/ed25519@npm:^2.1.0":
+"@noble/ed25519@npm:^2.0.0":
   version: 2.1.0
   resolution: "@noble/ed25519@npm:2.1.0"
   checksum: f9638d5daaaadaecf33cb09675668bde144cecb9a4467f78cda2a7fbd96a1b975a1f8d00e99599f840de52adc64e723333c7c8e52cdf85e3ef160d01b95c408c