Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

Withdrawal safety for all key L2->L1 events #186

Merged
merged 9 commits into from
Feb 28, 2024

Conversation

epociask
Copy link
Collaborator

@epociask epociask commented Nov 6, 2023

Withdrawal safety for all key L2->L1 events

Fixes Issue

Fixes #178

Changes proposed

  • Add two withdrawal safety variations (L1/L2)
  • Update L1 withdrawal safety to process WithdrawalFinalized events
  • Update E2E tests to ensure coverage at every user step for L2->L1 native bridge withdrawals

Screenshots (Optional)

Note to reviewers

@epociask epociask self-assigned this Nov 7, 2023
Copy link
Collaborator

@adrain-cb adrain-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets get this rebased and merged!

@cb-heimdall
Copy link
Collaborator

Review Error for adrain-cb @ 2024-02-06 02:57:51 UTC
User failed mfa authentication, see go/mfa-help

adrain-cb
adrain-cb previously approved these changes Feb 6, 2024
@cb-heimdall cb-heimdall dismissed adrain-cb’s stale review February 26, 2024 22:32

Approved review 1866137561 from adrain-cb is now dismissed due to new commit. Re-request for approval.

@adrain-cb adrain-cb merged commit 41bc9fb into master Feb 28, 2024
12 checks passed
@adrain-cb adrain-cb deleted the withdrawal_safety_fixes branch February 28, 2024 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat - Support WithdrawalProven processing in withdrawal_safety heuristic
4 participants