Skip to content
This repository has been archived by the owner on May 29, 2024. It is now read-only.

withdrawal_safety heuristic #176

Merged
merged 42 commits into from
Nov 2, 2023
Merged

Conversation

epociask
Copy link
Collaborator

@epociask epociask commented Oct 26, 2023

Withdrawal Safety Heuristic

Fixes Issue

Fixes #

Changes proposed

  • Removed withdrawal_enforcement in favor of withdrawal_safety that performs more invariant checks within the heuristic
  • Added ActivationSet type thats returned for every heuristic assessment operation.
  • Forwarded .devnet allocations to the main repo to avoid having to build them for running E2E testing. Any regressions from this will be fixed in [issue-172] Version pinned devnet allocations #175
  • Updated E2E test to ensure withdrawal_safety operation

Screenshots (Optional)

Note to reviewers

Most changes in this PR are the result of .devnet being stored locally

@epociask epociask self-assigned this Oct 26, 2023
@epociask epociask added the type: enhancement New feature or request label Oct 26, 2023
@epociask epociask changed the title unsafe_withdrawal heuristic withdrawal_safety heuristic Oct 30, 2023
internal/common/units.go Outdated Show resolved Hide resolved
@epociask epociask merged commit 08b5755 into master Nov 2, 2023
9 checks passed
@epociask epociask deleted the epociask/unsafe-withdrawal-heuristic branch November 2, 2023 23:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants