Minor Tweaks - Typos, Contract Inv Verify Check, & Removed Comment Ac…

…tion (#109)
base-org · Jul 12, 2023 · 5e22d8e · 5e22d8e
1 parent 66a27c4
commit 5e22d8e
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 22 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -38,28 +38,28 @@ jobs:
       run: | 
         go test -coverprofile=coverage.out ./internal/... >> out.txt
 
-    - name: Generate Coverage
-      run: |
-        go tool cover -func=coverage.out | grep total | awk '{print $3}' >> out.txt
-        echo "::set-output name=coverage::$(cat out.txt)"
+    # - name: Generate Coverage
+    #   run: |
+    #     go tool cover -func=coverage.out | grep total | awk '{print $3}' >> out.txt
+    #     echo "::set-output name=coverage::$(cat out.txt)"
 
-    - name: Find Coverage Comment
-      uses: peter-evans/find-comment@v1
-      id: fc
-      with:
-        issue-number: ${{ github.event.pull_request.number }}
-        comment-author: 'github-actions[bot]'
-        body-includes: '### Current Test Coverage'
+    # - name: Find Coverage Comment
+    #   uses: peter-evans/find-comment@v1
+    #   id: fc
+    #   with:
+    #     issue-number: ${{ github.event.pull_request.number }}
+    #     comment-author: 'github-actions[bot]'
+    #     body-includes: '### Current Test Coverage'
 
-    - name: Add Coverage Comment
-      uses: actions/github-script@v6
-      env:
-        DATA: ${{ steps.fc.outputs.comment-id }}
+    # - name: Add Coverage Comment
+    #   uses: actions/github-script@v6
+    #   env:
+    #     DATA: ${{ steps.fc.outputs.comment-id }}
 
-      with:
-        script: | 
-          const script = require('./.github/scripts/comment.js')
-          await script({github, context, core})
+    #   with:
+    #     script: | 
+    #       const script = require('./.github/scripts/comment.js')
+    #       await script({github, context, core})
 
   e2e-test:
     runs-on: ubuntu-latest

diff --git a/internal/engine/registry/contract_event.go b/internal/engine/registry/contract_event.go
@@ -65,7 +65,7 @@ func (ei *EventInvariant) Invalidate(td core.TransitData) (*core.InvalOutcome, b
 		return nil, false, err
 	}
 
-	if td.Address.String() != ei.cfg.Address {
+	if td.Address != common.HexToAddress(ei.cfg.Address) {
 		return nil, false, fmt.Errorf(invalidAddrErr, ei.cfg.Address, td.Address.String())
 	}
 

diff --git a/internal/etl/registry/pipe/event_log.go b/internal/etl/registry/pipe/event_log.go
@@ -94,8 +94,8 @@ func (ed *EventDefinition) Transform(ctx context.Context, td core.TransitData) (
 		return []core.TransitData{}, fmt.Errorf("could not convert to block")
 	}
 
-	// 2. Fetch the addresess and events to monitor for
-	logging.NoContext().Debug("Getting addresess",
+	// 2. Fetch the addresses and events to monitor for
+	logging.NoContext().Debug("Getting addresses",
 		zap.String(core.PUUIDKey, ed.pUUID.String()))
 
 	addresses, err := ed.ss.GetSlice(ctx, ed.sk)