[epociask/no-issue-withdrawal-enforce] Fixing lint erors

e2e/e2e.go

@@ -131,7 +131,6 @@ func CreateSysTestSuite(t *testing.T) *SysTestSuite {
 		Cfg: &cfg,
 		App: pess,
 		Close: func() {
-			kill()
 			sys.Close()
 		},
 		AppCfg:  appCfg,

e2e/e2e_test.go

@@ -27,15 +27,6 @@ import (
 	"github.com/base-org/pessimism/internal/api/models"
 )
 
-func calcGasFees(gasUsed uint64, gasTipCap *big.Int, gasFeeCap *big.Int, baseFee *big.Int) *big.Int {
-	x := new(big.Int).Add(gasTipCap, baseFee)
-	// If tip + basefee > gas fee cap, clamp it to the gas fee cap
-	if x.Cmp(gasFeeCap) > 0 {
-		x = gasFeeCap
-	}
-	return x.Mul(x, new(big.Int).SetUint64(gasUsed))
-}
-
 // Test_Balance_Enforcement ... Tests the E2E flow of a single
 // balance enforcement invariant session on L2 network.
 func Test_Balance_Enforcement(t *testing.T) {
@@ -241,6 +232,7 @@ func Test_Withdrawal_Enforcement(t *testing.T) {
 
 	// Deploy a dummy L2ToL1 message passer for testing.
 	fakeAddr, tx, _, err := bindings.DeployL2ToL1MessagePasser(transactor.L2Opts, l2Seq)
+	assert.NoError(t, err, "error deploying message passer on L2")
 
 	_, err = e2e.WaitForTransaction(tx.Hash(), l2Seq, txTimeoutDuration)
 
@@ -346,7 +338,7 @@ func Test_Withdrawal_Enforcement(t *testing.T) {
 	assert.Nil(t, err, "withdrawal should successfully prove")
 
 	// Wait for the transaction to appear in L1
-	receipt, err = e2e.WaitForTransaction(tx.Hash(), l1Client, txTimeoutDuration)
+	_, err = e2e.WaitForTransaction(tx.Hash(), l1Client, txTimeoutDuration)
 	assert.Nil(t, err, "withdrawal finalized on L1")
 	time.Sleep(1 * time.Second)
 

internal/engine/addressing.go

@@ -33,7 +33,6 @@ func (am *addressingMap) GetSUUIDsByPair(address common.Address, pUUID core.PUUI
 
 // Insert ... Inserts a new entry into the addressing map
 func (am *addressingMap) Insert(addr common.Address, pUUID core.PUUID, sUUID core.SUUID) error {
-
 	if _, found := am.m[addr]; !found {
 		am.m[addr] = make(map[core.PUUID][]core.SUUID)
 		am.m[addr][pUUID] = []core.SUUID{sUUID}

internal/engine/addressing_test.go

@@ -35,11 +35,13 @@ func Test_GetSUUIDsByPair(t *testing.T) {
 	assert.NoError(t, err, "should not error")
 
 	ids, err = am.GetSUUIDsByPair(address, testPUUID)
+	assert.NoError(t, err, "should not error")
 	assert.Len(t, ids, 2, "should have length of 2")
 	assert.Contains(t, ids, sUUID, "should contain sUUID")
 	assert.Contains(t, ids, sUUID2, "should contain sUUID2")
 
 	// Test for not found
 	ids, err = am.GetSUUIDsByPair(address, core.NilPUUID())
 	assert.Error(t, err, "should error")
+	assert.Empty(t, ids, "should be empty")
 }

internal/engine/manager.go

@@ -208,7 +208,6 @@ func (em *engineManager) executeAddressInvariants(ctx context.Context, data core
 		}
 
 		em.executeInvariant(ctx, data, inv)
-
 	}
 }