Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rkrausse oil timer #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Oct 9, 2019

Shouldn't that more or less solve the lag spike issue?
I tested the mod with ores and oil. Works like a charm.

Robert Krauße added 7 commits October 9, 2019 19:22
Removed general interval for all resources and replaced it with an interval for oil only.
@barthuijgen
Copy link
Owner

I have somehow completely missed that this PR opened. I think it does solve the lag spike mostly. I originally did like being able to refill the ore without it depleting, but there's no real benefit there so might as well leave it out I suppose.

You also removed the option to disable, which makes sense as it did cause some issues for multiplayer as well. But I wonder what the lag spike on refresh is on big maps even when it's only doing oil.

Did you perform any tests regarding this? I don't think i have a big map save at the moment.

@ghost
Copy link
Author

ghost commented Jan 20, 2020

I've tested it on my own, relatively big map, yes. How big is it? Traveling around the map by train, end to end, takes more than a minute. But not on a huuuuge map. My dedicated server is running stable with this change, no problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant