Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AWS support object mutation #142

Merged
merged 2 commits into from
Aug 14, 2024
Merged

feat: AWS support object mutation #142

merged 2 commits into from
Aug 14, 2024

Conversation

csatib02
Copy link
Member

@csatib02 csatib02 commented Aug 8, 2024

Overview

  • This PR enables AWS Object mutation.

Part of #62

@csatib02 csatib02 requested a review from a team as a code owner August 8, 2024 12:49
@csatib02 csatib02 requested review from akijakya and removed request for a team August 8, 2024 12:49
@csatib02 csatib02 self-assigned this Aug 8, 2024
@github-actions github-actions bot added the size/L Denotes a PR that changes 500-999 lines label Aug 8, 2024
@csatib02 csatib02 added area/provider/aws kind/feature Categorizes issue or PR as related to a new feature. and removed size/L Denotes a PR that changes 500-999 lines labels Aug 8, 2024
ramizpolic
ramizpolic previously approved these changes Aug 13, 2024
Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/provider/aws/common.go Outdated Show resolved Hide resolved
pkg/provider/aws/common.go Outdated Show resolved Hide resolved
pkg/provider/aws/common.go Outdated Show resolved Hide resolved
pkg/provider/bao/configmap.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the size/L Denotes a PR that changes 500-999 lines label Aug 14, 2024
Signed-off-by: Bence Csati <[email protected]>

feat: enable AWS object mutation

Signed-off-by: Bence Csati <[email protected]>
Signed-off-by: Bence Csati <[email protected]>
@github-actions github-actions bot added size/M Denotes a PR that changes 100-499 lines and removed size/L Denotes a PR that changes 500-999 lines labels Aug 14, 2024
@csatib02 csatib02 merged commit d60c1b7 into main Aug 14, 2024
26 checks passed
@csatib02 csatib02 deleted the feat/aws-support-object branch August 14, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/aws kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants