New ordered name (#724)

* Replace univariate_ordered with ordered * pin numpy<1.26.0
bambinos · Sep 21, 2023 · 169564f · 169564f
1 parent bbc2cb1
commit 169564f
Show file tree

Hide file tree

Showing 4 changed files with 101 additions and 140 deletions.
diff --git a/bambi/priors/scaler.py b/bambi/priors/scaler.py
@@ -108,7 +108,7 @@ def scale_threshold(self):
                     "Normal",
                     mu=mu,
                     sigma=1,
-                    transform=pm.distributions.transforms.univariate_ordered,
+                    transform=pm.distributions.transforms.ordered,
                 )
         elif isinstance(self.model.family, StoppingRatio):
             threshold = self.model.components["threshold"]

diff --git a/pyproject.toml b/pyproject.toml
@@ -18,7 +18,7 @@ dependencies = [
     "arviz>=0.12.0",
     "formulae>=0.5.0",
     "graphviz",
-    "numpy>1.22",
+    "numpy>1.22,<1.26.0",
     "pandas>=1.0.0",
     "pymc>=5.5.0",
     "pytensor>=2.12.3",

diff --git a/tests/test_built_models.py b/tests/test_built_models.py
@@ -941,11 +941,11 @@ def test_cumulative_family_priors(inhaler):
             "Normal",
             mu=[-0.5, 0, 0.5],
             sigma=1.5,
-            transform=pm.distributions.transforms.univariate_ordered,
+            transform=pm.distributions.transforms.ordered,
         )
     }
     model = bmb.Model(
-        "rating ~ period + carry + treat", inhaler, family="cumulative", priors=priors
+        "rating ~ 0 + period + carry + treat", inhaler, family="cumulative", priors=priors
     )
     model.fit(tune=100, draws=100)