Handle ruff warnings #215
Merged
Handle ruff warnings #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrit
force-pushed
the
handle_ruff_warnings
branch
from
b000aef
to
df765bf
Compare
patrit
force-pushed
the
handle_ruff_warnings
branch
from
df765bf
to
5495fc1
Compare
christiansiegel
approved these changes
Nov 8, 2023
| @@ -80,7 +80,7 @@ def __update_values(self, git_repo: GitRepo) -> dict[str, Any]: | |||
| single_commit = args.single_commit or args.commit_message | |||
| full_file_path = git_repo.get_full_file_path(args.file) | |||
| updated_values = {} | |||
| for key, value in args.values.items(): | |||
| for key, value in args.values.items(): # noqa: PD011 | |||
There was a problem hiding this comment.
this seems like a false positive 🤔
| @@ -4,7 +4,7 @@ | |||
|
|
|||
|
|
|||
| def create_tmp_dir() -> str: | |||
| tmp_dir = f"/tmp/gitopscli/{uuid.uuid4()}" | |||
| tmp_dir = f"/tmp/gitopscli/{uuid.uuid4()}" # noqa: S108 | |||
There was a problem hiding this comment.
Cleaning these up might be a step towards windows support (#187)
Comment on lines
81
to
+82
| current = work_path.copy().items() | ||
| for key, value in current: | ||
| for key, _ in current: |
There was a problem hiding this comment.
Could just drop items() to iterate over the keys
|
🎉 This issue has been resolved in version 5.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of ruff warning cleanup. May be subject to discussions.