Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor(select): create new component option-list #1357

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

closes #1355

@github-actions github-actions bot added the ♻️ refactor Improve existing code label Mar 18, 2024
Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 1:22pm

Copy link

changeset-bot bot commented Mar 18, 2024

🦋 Changeset detected

Latest commit: 7f990d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@baloise/ds-core Minor
@baloise/ds-angular-common Minor
@baloise/ds-angular-legacy Minor
@baloise/ds-angular-module Minor
@baloise/ds-angular Minor
@baloise/ds-react Minor
@baloise/ds-table Minor
@baloise/ds-testing Minor
@baloise/ds-vue Minor
docs Patch
e2e Patch
@baloise/ds-brand-icons Minor
@baloise/ds-css Minor
@baloise/ds-devkit Minor
@baloise/ds-favicons Minor
@baloise/ds-fonts Minor
@baloise/ds-icons Minor
@baloise/ds-maps Minor
@baloise/ds-styles Minor
@baloise/ds-tokens Minor
@baloise/ds-nx Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@incubator-tekton
Copy link

🚀 Welcome to Baloise ChatOps based GitOps Bot 🎉

- If you want to enable preview environments for this PullRequest, comment with `/preview`. 
- If you want to disable the preview environment for this PR, comment with `/undeploy`. 
- If you need help or want to see the docs, comment with `/help`. 
                            
Make sure to refresh this page after submitting a command.
Preview environments can be redeployed automatically if you enable the webhook for updates to the source branch. :new:

Have fun building awesome apps! :hammer:  :whale2:  :truck:  :ship:

@hirsch88 hirsch88 changed the base branch from main to refactor/select March 18, 2024 15:15
@hirsch88
Copy link
Member

hirsch88 commented Mar 19, 2024

📸 Create Base Image finished!

Specs: bal-option-list.visual.cy.ts

Check out the action on GitHub ↗︎

@hirsch88 hirsch88 merged commit b09e821 into refactor/select Mar 19, 2024
16 checks passed
@hirsch88 hirsch88 deleted the refactor/issue-1355 branch March 19, 2024 13:27
hirsch88 added a commit that referenced this pull request Apr 17, 2024
* Create PR for #1349

* ♻️ refactor(select): create option component (#1356)

* Create PR for #1354

* add new component option

* add new component option

* fix a11y issues

* add interface of the component

* add output for visuals

* adjust ci

* update gitignore

* update base images

* adjust colors and sass vars

* update base images

* merge

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <[email protected]>
Co-authored-by: hirsch88 <[email protected]>

* ♻️ refactor(select): create new component option-list (#1357)

* Create PR for #1355

* add option list component

* update base images

* add labelledby for a11y

* add changeset

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <[email protected]>
Co-authored-by: hirsch88 <[email protected]>

* add first dropdown draft

* update spinner

* refactor in to utils

* format files

* update with prop options

* add docs

* format files

* support testing

* chore: Merge branch 'main' into refactor/issue-1349

* adjust component testing

* update component testing

* add component test for dropdown

* update dropdown

* update dropdown

* update dropdown

* autocomplete

* rename

* update dropdown

* update dropdown

* format files

* add a11y test

* add viusal tests

* update base images

* format files

* update angular output

* add testing lib migration

* update docs

* add required

* fix tests

* fix tests

* update docs

* chores

* create angular e2e test

* create angular e2e test

* fix doc styles

* update base images

* update docs

* fix chip hover

* remove old styles

* adjust invalid and disabled with chips

* fix z-index

* update multiple always with checkbox and improve form submit

* update multiple always with checkbox and improve form submit

* hide native select for a11y

* fix checkbox issue

* add log for visual type

* fix visual

* update base images

* update base images

* finish auto-fill

* fix safari autofill

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <[email protected]>
Co-authored-by: hirsch88 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ refactor Improve existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ refactor(select): create new component option-list
2 participants