Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple output binding support #603

Merged
merged 17 commits into from
Jan 26, 2023

Conversation

xlight05
Copy link
Contributor

@xlight05 xlight05 commented Jan 26, 2023

Purpose

$Subject and minor fixes
Resolves ballerina-platform/module-ballerinax-azure.functions#586

TODO -
Disables few cosmosdb related fields as they are not supported for now - ballerina-platform/ballerina-library#7071

Minor Fixes and improvements -
Resolves ballerina-platform/module-ballerinax-azure.functions#594
Resolves ballerina-platform/module-ballerinax-azure.functions#591
Resolves ballerina-platform/module-ballerinax-azure.functions#590
Resolves ballerina-platform/module-ballerinax-azure.functions#589
Resolves ballerina-platform/module-ballerinax-azure.functions#588
Resolves ballerina-platform/module-ballerinax-azure.functions#587
Resolves ballerina-platform/module-ballerinax-azure.functions#562

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Base: 70.81% // Head: 79.63% // Increases project coverage by +8.81% 🎉

Coverage data is based on head (fce0175) compared to base (a61545f).
Patch coverage: 83.89% of modified lines in pull request are covered.

❗ Current head fce0175 differs from pull request most recent head 93c8bf1. Consider uploading reports for the commit 93c8bf1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     ballerina-platform/module-ballerinax-azure.functions#603      +/-   ##
============================================
+ Coverage     70.81%   79.63%   +8.81%     
- Complexity      490      643     +153     
============================================
  Files            74       76       +2     
  Lines          2265     2499     +234     
  Branches        338      405      +67     
============================================
+ Hits           1604     1990     +386     
+ Misses          489      311     -178     
- Partials        172      198      +26     
Impacted Files Coverage Δ
.../java/org/ballerinax/azurefunctions/Constants.java 0.00% <ø> (ø)
...org/ballerinax/azurefunctions/service/Binding.java 100.00% <ø> (+30.76%) ⬆️
...functions/exceptions/UnsupportedTypeException.java 0.00% <0.00%> (ø)
...lerinax/azurefunctions/AzureCodeGeneratedTask.java 93.75% <33.33%> (-4.03%) ⬇️
...ava/io/ballerina/stdlib/azure/functions/Utils.java 65.85% <50.00%> (-1.72%) ⬇️
.../main/java/org/ballerinax/azurefunctions/Util.java 77.35% <73.68%> (+0.88%) ⬆️
...ions/validators/output/OutputBindingValidator.java 79.56% <79.56%> (ø)
...zurefunctions/service/http/HTTPTriggerBinding.java 76.97% <83.33%> (+10.31%) ⬆️
...unctions/validators/http/HttpServiceValidator.java 81.42% <85.89%> (ø)
...erina/stdlib/azure/functions/FunctionCallback.java 83.07% <87.50%> (+3.47%) ⬆️
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xlight05 xlight05 merged commit 2d89aa6 into ballerina-platform:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants