Fix review comments

ballerina-platform · May 10, 2024 · 0db30cb · 0db30cb
1 parent e843916
commit 0db30cb
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/build-config/spotbugs-exclude.xml b/build-config/spotbugs-exclude.xml
@@ -18,10 +18,12 @@
 <FindBugsFilter>
     <Match>
         <Class name="io.ballerina.lib.avro.Utils" />
+        <!-- <Method name = "getMutableType" /> -->
         <Bug pattern="BC_UNCONFIRMED_CAST" />
     </Match>
     <Match>
         <Class name="io.ballerina.lib.avro.deserialize.visitor.DeserializeVisitor" />
+        <!-- <Method name = "visit" /> -->
         <Bug pattern="BC_UNCONFIRMED_CAST" />
     </Match>
 </FindBugsFilter>
diff --git a/native/src/main/java/io/ballerina/lib/avro/Utils.java b/native/src/main/java/io/ballerina/lib/avro/Utils.java
@@ -22,7 +22,6 @@
 import io.ballerina.runtime.api.creators.ErrorCreator;
 import io.ballerina.runtime.api.types.IntersectionType;
 import io.ballerina.runtime.api.types.Type;
-import io.ballerina.runtime.api.types.UnionType;
 import io.ballerina.runtime.api.utils.StringUtils;
 import io.ballerina.runtime.api.utils.TypeUtils;
 import io.ballerina.runtime.api.values.BError;
@@ -51,13 +50,6 @@ public static Type getMutableType(Type dataType) {
         IntersectionType intersectionType = (IntersectionType) dataType;
         for (Type type : intersectionType.getConstituentTypes()) {
             Type referredType = TypeUtils.getImpliedType(type);
-            if (referredType.getTag() == TypeTags.UNION_TAG) {
-                for (Type elementType : ((UnionType) referredType).getMemberTypes()) {
-                    if (elementType.getTag() != TypeTags.NULL_TAG) {
-                        return elementType;
-                    }
-                }
-            }
             if (TypeUtils.getImpliedType(intersectionType.getEffectiveType()).getTag() == referredType.getTag()) {
                 return referredType;
             }

diff --git a/native/src/main/java/io/ballerina/lib/avro/deserialize/Deserializer.java b/native/src/main/java/io/ballerina/lib/avro/deserialize/Deserializer.java
@@ -30,7 +30,7 @@ public abstract class Deserializer {
     private final Type type;
 
     public Deserializer() {
-        this(null);
+        this(null, null);
     }
 
     public Deserializer(Type type) {