Provide completions for expressions in the expression editor #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipunayf
added
the
Area/FlowModel
nipunayf
requested review from
madushajg,
sachiniSam,
keizer619 and
azinneera
as code owners
nipunayf
force-pushed
the
completions-api
branch
from
e2d6b1a
to
3de5ce6
Compare
|
@sachiniSam Do we need more functionalities for the expression editor? |
nipunayf
force-pushed
the
completions-api
branch
from
3de5ce6
to
fc7db66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the expression editor lacks access to the source code, it cannot retrieve completions from the text document. To address this, a LS API,
expressionEditor/completions, appends changes to a temporary project to obtain the necessary completions.Remarks
Duplicating the project introduces significant complexity in terms of both performance and memory, as it duplicates memory usage and involves many I/O operations. Therefore, we should explore an approach where the expression editor retrieves completions from the original project. This would be feasible if the state in which the user uses the expression editor does not trigger the other APIs.