Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constant product pool & hooks page #56

Merged
merged 12 commits into from
Jul 12, 2024
Merged

Add constant product pool & hooks page #56

merged 12 commits into from
Jul 12, 2024

Conversation

MattPereira
Copy link
Member

@MattPereira MattPereira commented Jul 9, 2024 •
edited
Loading

Closes #54
Closes #55

Summary

  • Added the ConstantProductPool
  • Simplified the steps to deploy by running all the deploy scripts with just yarn deploy
  • Still have option to deploy just a pool afterwords with yarn deploy:sum and yarn deploy:product
    • Each pool script sets its own registration & initialization config with helper functions
  • Streamlined minting mock tokens on the pools page
  • Added a hooks page that pulls data from Balancer's new curated hook list
  • Updated README to reflect all the changes
  • Recorded a new demo video focused on just quickstart & introduction:

image

@MattPereira MattPereira changed the title Add constant product pool Add constant product pool & hooks page Jul 12, 2024
@MattPereira MattPereira marked this pull request as ready for review July 12, 2024 06:04
MattPereira
MattPereira commented Jul 12, 2024
View reviewed changes
Copy link
Member Author

@MattPereira MattPereira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is Sepolia network experiencing some crazy gas price spike rn 😅

image

image

johngrantuk
johngrantuk approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@johngrantuk johngrantuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I like the change in the deploy scripts 👏

@MattPereira
Copy link
Member Author

My guess is Sepolia network experiencing some crazy gas price spike rn 😅

image

giphy

@MattPereira MattPereira merged commit da37bce into main Jul 12, 2024
1 check passed
@MattPereira MattPereira deleted the add-constant-product-pool branch July 14, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngrantuk johngrantuk johngrantuk approved these changes

@brunoguerios brunoguerios Awaiting requested review from brunoguerios

@mkflow27 mkflow27 Awaiting requested review from mkflow27

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve CI Checks Add Constant Product Pool
2 participants
@MattPereira @johngrantuk