Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter & better organize foundry dependencies #53

Merged
merged 14 commits into from
Jul 8, 2024

Conversation

MattPereira
Copy link
Member

@MattPereira MattPereira commented Jul 6, 2024

Closes #42

Summary

  • Added the Lint workflow back to ensure dependencies and type safety
  • Moved the v3-monorepo dependencies out of the root package.json into the foundry/package.json, which fixed the local contract import complaints shown in Fix Dependencies and Linter #42
  • Shoveled the HelperFunctions into HelperConfig to simplify script inheritance
  • Changed Permit2 dependency to be a git submodule in the foundry/lib folder because of issues with checksum in yarn.lock on different machines. I think this will be more reliable

@MattPereira MattPereira merged commit ce353d4 into main Jul 8, 2024
1 check passed
@MattPereira MattPereira mentioned this pull request Jul 8, 2024
@MattPereira MattPereira deleted the fix-foundry-dependency-mess branch July 11, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Dependencies and Linter
1 participant