Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Housekeeping #44

Merged
merged 4 commits into from
Jun 17, 2024
Merged

General Housekeeping #44

merged 4 commits into from
Jun 17, 2024

Conversation

MattPereira
Copy link
Member

@MattPereira MattPereira commented Jun 14, 2024

Closes #41

Summary

  • Renamed all the references to "join" and "exit" to be "Add Liquidity" and "Remove Liquidity" instead to be more consistent with docs and monorepo
  • Extended scaffoldConfig to allow for a targetFork network and ammended README accordingly
  • Added a custom hook useTargetFork to consolidate some of logic used by SDK queries
  • Cleaned up some type safety in the pool action hooks and form components

@MattPereira MattPereira changed the title Rename "join" to "add liquidity" and "exit" to "remove liquidity" General Housekeeping Jun 16, 2024
@MattPereira MattPereira marked this pull request as ready for review June 17, 2024 04:16
Copy link
Member

@johngrantuk johngrantuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any idea why the lint is failing?

@MattPereira
Copy link
Member Author

@johngrantuk

Any idea why the lint is failing?

Ya its failing on the Lint workflow step where it tries to install dependencies in the GHA cloud environment. I think this is because the v3 monorepo is private so it would require github authentication to be successful which I think involves setting a repository secret. I don't have access to repo settings to attempt the fix, but happy to research it further if you like.

Other options could be removing the Install dependencies step from the Lint work flow or being okay with it failing until the monorepo goes public

- name: Install dependencies
run: yarn install --immutable

Screenshot from 2024-06-17 06-52-43

@MattPereira MattPereira merged commit bcaf549 into main Jun 17, 2024
1 check failed
@MattPereira MattPereira deleted the rename-join-and-exit branch June 18, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General Housekeeping Tasks
2 participants