Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing asset managers to ComposableStablePool #2142

Closed
wants to merge 1 commit into from

Conversation

sajal
Copy link

@sajal sajal commented Dec 21, 2022

Description

This PR allows the ability to pass asset managers when deploying ComposableStablePool. Previously the contract hardcoded zero-address.

Background info at #2141.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

Fixes #2141

@EndymionJkb
Copy link
Collaborator

Asset managers are extremely powerful: they can withdraw all funds. Allowing pools to be deployed from the canonical factory with arbitrary asset managers would greatly compromise security.

The safe way to deploy a pool with asset managers is illustrated by Linear and Managed Pools: make a factory that deploys both the pool and a specific asset manager contract (e.g., a LinearPoolRebalancer or pool controller). Then users would be able to review the contracts and determine the safety of pools deployed from that factory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composable Stable Pool should take AssetManager in ctor
2 participants