Add version to managed pool #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubeira
changed the base branch from
i-hate-solc-and-everything-with-it
to
fix-benchmarks-managed-pool-refactor
|
Let's review after the dust in #2078 is settled. |
Base automatically changed from
fix-benchmarks-managed-pool-refactor
to
i-hate-solc-and-everything-with-it
December 1, 2022 15:11
nventuro
approved these changes
Dec 1, 2022
|
Merge once CI passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Built on top of #2078 (merge it first, then sync this branch with master, and target master).
As with composable stable pools, extending
VersioninManagedPoolorManagedPoolSettingscauses a stack too deep error; that's why we only implement the interface inManagedPool. This shall be solved by movingVersionto the base pool layer, so that we don't need to reimplement it on every pool.Type of change
Checklist:
master, or there's a description of how to mergeIssue Resolution
See #2026.