Add FeeDistributorBALClaimer contract #1212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
force-pushed
the
fee-distribution-veBAL-claimer
branch
3 times, most recently
from
4b9e0be
to
4228761
Compare
|
I'll fix these issues once #1191 is merged, building on top of non-merged branches is annoying. |
dmf7z
reviewed
Mar 31, 2022
pkg/liquidity-mining/contracts/fee-distribution/FeeDistributorBALClaimer.sol
Show resolved
Hide resolved
TomAFrench
force-pushed
the
fee-distribution-veBAL-claimer
branch
from
83e4960
to
be4ace5
Compare
nventuro
reviewed
Apr 5, 2022
pkg/liquidity-mining/contracts/fee-distribution/FeeDistributorBALClaimer.sol
Show resolved
Hide resolved
TomAFrench
commented
Apr 7, 2022
pkg/liquidity-mining/contracts/fee-distribution/FeeDistributorBALClaimer.sol
Outdated
Show resolved
Hide resolved
# Conflicts: # pkg/interfaces/contracts/liquidity-mining/IStakelessGauge.sol # pkg/interfaces/contracts/standalone-utils/IBALTokenHolder.sol # pkg/liquidity-mining/contracts/gauges/StakelessGauge.sol # pkg/standalone-utils/contracts/BALTokenHolder.sol
* master: Automatically save the deployment tx hash on deployment (#1310) Update SNX impl input (#1309) Add implementation + deployment of the ProtocolFeesWithdrawer (#1301) minor update for consistency (#1306) fix: fix fork test for NoProtocolFeeLBP (#1304) ci: switch from infura to alchemy (#1305) Check deployment outputs (#1284) fix: use force argument in no fee LBP task (#1303) style: silence linter errors (#1302) change 'factory' to 'NoProtocolFeeLiquidityBootstrappingPoolFactory' (#1286) Double Entrypoint Fix Relayer (#1300)
|
I want to add a quick fork test to make sure that the BAL ends up in the right place before we deploy. |
* master: fix: stop storing deployment transactions for fork test deployments (#1311)
|
Closing for inactivity. #2281 is still open; we can revive the PR when we actively work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #1191
Currently the BAL emissions for veBAL holders are sent to a
BALTokenHoldercontract which the LM committee multisig has powers to withdraw from. This PR automates the process of distributing these tokens to veBAL holders.The
FeeDistributorBALClaimercontract allows anyone to call a function which willSingleRecipientGaugewhich is responsible for veBAL rewards.BALTokenHolderto theFeeDistributor.FeeDistributorto make it aware of the new BAL tokens it holds.