Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid an error when using the action #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid an error when using the action #1

wants to merge 1 commit into from

Conversation

svr333
Copy link

@svr333 svr333 commented Oct 3, 2022

Changes

Instead of it marking the action as failed, simply return silently.
This'll look nicer in the PR overview

@WalshyDev
Copy link

Moving my comment here so it isn't lost

Is there a need now it's fixed for external contributors?

@JustAHuman-xD
Copy link

Moving my comment here so it isn't lost

Is there a need now it's fixed for external contributors?

If something else was to error in the labeling or the action breaks in the future due to a change it would avoid the same issue happening.

@WalshyDev
Copy link

But it would also avoid us knowing about it :p

Good to know when errors happen rather than avoid them haha

@JustAHuman-xD
Copy link

fair enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalshyDev WalshyDev WalshyDev approved these changes

@JustAHuman-xD JustAHuman-xD JustAHuman-xD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svr333 @WalshyDev @JustAHuman-xD