make braft PeerId support hostname/dns. #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaolin310
force-pushed
the
braft-hostname
branch
2 times, most recently
from
cfa1256
to
60b7c0e
Compare
* add more constructor for PeerId. * modify PeerId operator<. * use brpc naming_service_url init channel API to force resolv dns. * modify raft_meta log saved format when PeerId type is HostName. * init channels only once and save them for future use
xiaolin310
force-pushed
the
braft-hostname
branch
from
60b7c0e
to
b3e8ad1
Compare
* define a struct named HostNameAddr, as an attribute of PeerId * wrap a function to build naming_service_url, which is used for brpc channel init * modify logic about channel init with naming service * minor fix about hostnameAddr port_ type
|
It would be really useful for braft to support hostname/dns for PeerId as it will allow it to be used on Kubernetes that dynamically assigns IPs. |
|
looks fine! but it's complex for me, I think you should replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an implement of Issue
#18