Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lock when accessing internal map #4482

Merged
merged 3 commits into from
Sep 23, 2024
Merged

fix: lock when accessing internal map #4482

merged 3 commits into from
Sep 23, 2024

Conversation

frrist
Copy link
Member

@frrist frrist commented Sep 19, 2024

wdbaruni
wdbaruni approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@wdbaruni wdbaruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but we should switch to RWMutex

pkg/lib/collections/hashed_priority_queue.go Outdated
Comment on lines 30 to 32
q.mu.Lock()
defer q.mu.Unlock()
_, ok := q.identifiers[id]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use RWMutex?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@frrist frrist added the th/game-day Issues reported during game day testing label Sep 23, 2024
@frrist frrist merged commit 756c5ac into main Sep 23, 2024
3 of 4 checks passed
@frrist frrist deleted the frrist/fix/priority-queu-panic branch September 23, 2024 20:20
@frrist frrist mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udsamani udsamani udsamani approved these changes

@wdbaruni wdbaruni wdbaruni approved these changes

Assignees
No one assigned
Labels
th/game-day Issues reported during game day testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node terminated with panic
3 participants
@frrist @wdbaruni @udsamani