Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeout job progress #4468

Merged
merged 4 commits into from
Sep 19, 2024
Merged

timeout job progress #4468

merged 4 commits into from
Sep 19, 2024

Conversation

udsamani
Copy link
Contributor

@udsamani udsamani commented Sep 18, 2024 •
edited
Loading

Screenshot 2024-09-19 005144

@udsamani udsamani self-assigned this Sep 18, 2024
wdbaruni
wdbaruni approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@wdbaruni wdbaruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. General feedback with similar PRs is to include a sample output of how things look like with the change

@udsamani
Copy link
Contributor Author

Looks good. General feedback with similar PRs is to include a sample output of how things look like with the change

Done

@udsamani udsamani linked an issue Sep 18, 2024 that may be closed by this pull request
job run doesn't exist for long running jobs #4421
Closed
@udsamani udsamani merged commit 07e89ff into main Sep 19, 2024
3 of 4 checks passed
@udsamani udsamani deleted the ud/timeout-job-progress branch September 19, 2024 00:09
@frrist frrist mentioned this pull request Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdbaruni wdbaruni wdbaruni approved these changes

Assignees

@udsamani udsamani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

job run doesn't exist for long running jobs
2 participants
@udsamani @wdbaruni