-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced WebUI #4406
Enhanced WebUI #4406
Conversation
var WebsocketUpgrader = websocket.Upgrader{ | ||
CheckOrigin: func(r *http.Request) bool { | ||
// TODO: make this more restricted or configurable | ||
return true | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed for streaming logs. previously we only enabled CORS for all APIs except websockets. We need to make this configurable or more restricted in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swagger API generation LGTM
@@ -1,81 +1,234 @@ | |||
package webui |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Improving the embedding web ui and making it compatible with our latest APIs.
How to test locally
Main changes in core bacalhau
@udsamani if you can please review these changes
Main changes in the ui http server
/_config
endpoint that the frontend calls when it loads to figure out the endpoints it needs to call@frrist if you can please review these changes. Just the webui/webui.go file
Main changes in the frontend
@aronchick a lot of code changes here, but are mainly generated code by openapi and other tools we are using. Still I would appreciate overall feedback on the component's implementations as I am not an expert in FE coding
Remaining work for follow up PRs
Open questions
Screenshots