Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not print usage and error and infer error codes in custom error handler #4405

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

udsamani
Copy link
Contributor

@udsamani udsamani commented Sep 11, 2024

This PR aims at the following

  • Do not print usage and error
  • HTTP Status Code infer in custom error handler

cmd/cli/job/describe.go Outdated Show resolved Hide resolved
@udsamani udsamani self-assigned this Sep 12, 2024
Copy link
Member

@wdbaruni wdbaruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments and you should be able to merge after addressing them

pkg/jobstore/errors.go Outdated Show resolved Hide resolved
pkg/models/error.go Outdated Show resolved Hide resolved
pkg/models/error.go Outdated Show resolved Hide resolved
pkg/publicapi/middleware/error_handler.go Outdated Show resolved Hide resolved
cmd/cli/job/describe.go Outdated Show resolved Hide resolved
@udsamani udsamani merged commit ae552cf into main Sep 12, 2024
4 checks passed
@udsamani udsamani deleted the cobra-unused branch September 12, 2024 08:42
frrist pushed a commit that referenced this pull request Sep 12, 2024
…ndler (#4405)

This PR aims at the following

- Do not print usage and error
- HTTP Status Code infer in custom error handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants