Move linters to github actions #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossjones
force-pushed
the
3288-ga-lint
branch
3 times, most recently
from
f69007c
to
23079e3
Compare
rossjones
changed the title
simonwo
reviewed
Jan 22, 2024
|
Is it possible to prevent tests from running until the linter passes? i.e. don't waste time on tests if linting fails? |
aronchick
approved these changes
Jan 22, 2024
Undesirable – at best, you then need to wait for the linter to run and pass again before knowing what tests failed. There's no issue with wasting time. |
rossjones
force-pushed
the
3288-ga-lint
branch
from
69f9bfc
to
a022219
Compare
|
@simonwo @aronchick everything's passing now, but it's still waiting for the old 'lint' check which is never going to run. Is it possible for you to remove it from the list in settings please as I don't have access. |
rossjones
force-pushed
the
3288-ga-lint
branch
from
9b9042c
to
75a383f
Compare
rossjones
force-pushed
the
3288-ga-lint
branch
from
75a383f
to
a9da994
Compare
aronchick
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the precommit linters to github actions to free up a little space in CircleCI.
We also remove
go vetas it's already part of golangci-lint.Fixes #3288