Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving spelling file to its own directory (for vscode integration) and skipping draft PRs #3280

Merged
merged 32 commits into from
Feb 1, 2024
Merged

Moving spelling file to its own directory (for vscode integration) and skipping draft PRs #3280

merged 32 commits into from
Feb 1, 2024

Conversation

aronchick
Copy link
Collaborator

…d skipping draft PRs on CI

@aronchick aronchick requested review from simonwo, wdbaruni, alaric-rd, olgibbons and a team and removed request for simonwo, wdbaruni, alaric-rd and olgibbons January 21, 2024 19:47
simonwo
simonwo previously requested changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@simonwo simonwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not seen any discussion about skipping draft PRs. What's the thinking behind that? I would prefer they run in CI.

@aronchick
Copy link
Collaborator Author

I've not seen any discussion about skipping draft PRs. What's the thinking behind that? I would prefer they run in CI.

Our build pipeline often takes 10 minutes+ to run. If a PR is in draft, why would we want it to run? The developer of the PR is saying it's not ready for review.

@wdbaruni
Copy link
Member

I've not seen any discussion about skipping draft PRs. What's the thinking behind that? I would prefer they run in CI.

Our build pipeline often takes 10 minutes+ to run. If a PR is in draft, why would we want it to run? The developer of the PR is saying it's not ready for review.

Generally the developer should wait for the CI checks to pass before publishing the PR and marking it ready for review

@aronchick
Copy link
Collaborator Author

I guess my issue is that if draft PRs are slowing actual ready to ship PRs, that seems not ideal.

@aronchick aronchick added the th/cicd Theme: Concerns continuous integration and build systems label Jan 22, 2024
@aronchick aronchick added circle-ci and removed th/cicd Theme: Concerns continuous integration and build systems labels Jan 22, 2024
@aronchick aronchick added the wip label Jan 23, 2024
@aronchick aronchick removed the wip label Jan 23, 2024
@aronchick aronchick requested a review from a team January 23, 2024 02:47
aronchick
aronchick commented Jan 23, 2024
View reviewed changes
Copy link
Collaborator Author

@aronchick aronchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been removed - it's now label based.

@aronchick aronchick removed the request for review from simonwo January 24, 2024 17:10
frrist
frrist approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@frrist frrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Might add a note in the CONTRIBUTING.md stating PR's labeled wit 'do-not-merge' or 'wip' will not trigger CI.

aronchick
aronchick commented Feb 1, 2024
View reviewed changes
Copy link
Collaborator Author

@aronchick aronchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@aronchick aronchick dismissed simonwo’s stale review February 1, 2024 00:16

no longer relevant

@aronchick aronchick merged commit 2b314bf into main Feb 1, 2024
12 checks passed
@aronchick aronchick deleted the 3279-only-run-ci-on-non-draft branch February 1, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frrist frrist frrist approved these changes

@simonwo simonwo simonwo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aronchick @wdbaruni @simonwo @frrist