WIP: Enqueue evaluations automatically rather than manually #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossjones
force-pushed
the
enqueuing-evaluations
branch
3 times, most recently
from
eeba576
to
91aac9e
Compare
To be able to process new evaluations being created, we need to be able to do so without blocking the process generating the evaluations (and notifications). This commit adds a worker pool which allows us to process messages of a known generic type, and control how buffered (or not) the input channel is, and how many worker routines will exist to process the messages. We must be aware though that if we are writing to the database, there will be a lock on the single db writer.
rossjones
force-pushed
the
enqueuing-evaluations
branch
from
91aac9e
to
f798a17
Compare
|
@wdbaruni closing this as well, feel free to re-open as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO