fixme: unable to test export of vp dst cache #582
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO: vp dst cache | ||
| // since events are needed to test and I cant update the power dist, the check for | ||
| // power distribution will be done in another gen export | ||
| // TODO: vp dst cache, comes with empty dst cache :/ |
There was a problem hiding this comment.
The reason is that we didn't add covenant signatures to these BTC delegations. AddDelegation adds the BTC delegation to the KV store, but it remains as pending state. Only after it receives covenant signatures, it will become active, thereby having voting power. Covenant signatures are added via AddCovenantSigs function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.