Use get instead of property to keep it more jQuery like.

ba-st · May 23, 2018 · 61ee37c · 61ee37c
1 parent ce12cf3
commit 61ee37c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/source/Willow-Tests/ScrollIntoViewCommandTest.class.st b/source/Willow-Tests/ScrollIntoViewCommandTest.class.st
@@ -39,7 +39,7 @@ ScrollIntoViewCommandTest >> testModelLoadingActions [
 
 	self
 		assert: html
-		equals: '<a id="id1"></a><script type="text/javascript">$("#id1").click(function(){$("#id8").each(function(){$(this)[0].scrollIntoView()})});</script>'
+		equals: '<a id="id1"></a><script type="text/javascript">$("#id1").click(function(){$("#id8").each(function(){$(this).get(0).scrollIntoView()})});</script>'
 ]
 
 { #category : #'tests-accessing' }

diff --git a/source/Willow/ScrollIntoViewCommand.class.st b/source/Willow/ScrollIntoViewCommand.class.st
@@ -38,10 +38,12 @@ ScrollIntoViewCommand >> initializeWithComponentIdentifierProvidedBy: anIdentifi
 { #category : #accessing }
 ScrollIntoViewCommand >> modelLoadingActions [
 
+	"We iterate the result before sending the scrolling message in case no match is found."
+
 	^ Array
 		with: [ :aScript :aCanvas | 
 			aScript << (aCanvas jQuery id: self identifierToShow)
-				each: ((aCanvas jQuery this property: 0) call: 'scrollIntoView') ]
+				each: ((aCanvas jQuery this get: 0) call: 'scrollIntoView') ]
 ]
 
 { #category : #accessing }