Merge pull request #197 from ba-st/196-improve-value-changing

Added beIdentifiable message to input views

source/Willow-Core-Tests/AsynchronicButtonWebViewTest.class.st

@@ -7,6 +7,17 @@ Class {
 	#category : #'Willow-Core-Tests-WebViews'
 }
 
+{ #category : #'tests-rendering' }
+AsynchronicButtonWebViewTest >> testBeIdentifiable [
+
+	| button html |
+
+	button := AsynchronicButtonWebView labeled: 'Click me!'.
+	button beIdentifiable.
+	html := self render: button.
+	self assert: html equals: '<button id="button-id1" type="button">Click me!</button>'
+]
+
 { #category : #'tests-rendering' }
 AsynchronicButtonWebViewTest >> testIdentifierOn [
 

source/Willow-Core-Tests/CheckboxWebViewTest.class.st

@@ -13,6 +13,20 @@ CheckboxWebViewTest >> newBinaryChoiceView [
 	^ CheckboxWebView onModel: true offModel: false
 ]
 
+{ #category : #'tests-configuring' }
+CheckboxWebViewTest >> testBeIdentifiable [
+
+	| html binaryChoiceView |
+
+	binaryChoiceView := self newBinaryChoiceView.
+	binaryChoiceView beIdentifiable.
+	html := self render: binaryChoiceView.
+
+	self
+		assert: html
+		equals: '<input checked name="1" id="checkbox-id2" type="checkbox"/><input name="3" type="hidden"/>'
+]
+
 { #category : #'tests-rendering' }
 CheckboxWebViewTest >> testIdentifierOn [
 

source/Willow-Core-Tests/CombinedWebInteractionInterpreterTest.class.st

@@ -662,18 +662,19 @@ CombinedWebInteractionInterpreterTest >> testSetValueToThenTriggerChangeOf [
 ]
 
 { #category : #'tests - Configuring - DOM' }
-CombinedWebInteractionInterpreterTest >> testSetValueToWithoutTriggeringChangeOnComponentWithId [
+CombinedWebInteractionInterpreterTest >> testSetValueToWithoutTriggeringChangeOf [
 
 	| interpreter html id |
 
 	interpreter := self combinedInterpreter.
 	id := '15'.
-
-	interpreter setValueTo: [ 'Ok' ] withoutTriggeringChangeOnComponentWithId: id.
-
 	html := self
 		renderUsing: [ :canvas | 
-			canvas textInput id: id.
+			| textInput |
+
+			textInput := canvas textInput id: id.
+			interpreter setValueTo: [ 'Ok' ] withoutTriggeringChangeOf: textInput.
+
 			canvas
 				render: okButton;
 				render: cancelButton

source/Willow-Core-Tests/ComponentValueSettingCommandTest.class.st

@@ -14,7 +14,9 @@ Class {
 ComponentValueSettingCommandTest >> setUp [
 
 	super setUp.
-	command := ComponentValueSettingCommand obtainingIdentifierFrom: [ 'id-12' ] valueFrom: [ '3' ]
+	command := ComponentValueSettingCommand
+		withoutTriggeringChangesObtainingIdentifierFrom: [ 'id-12' ]
+		valueFrom: [ '3' ]
 ]
 
 { #category : #'tests-accessing' }
@@ -29,8 +31,9 @@ ComponentValueSettingCommandTest >> testModelLoadingActionsWithoutSettingPreviou
 			script := canvas javascript.
 			input := canvas textInput.
 
-			( ComponentValueSettingCommand triggeringChangesOn: input withValueFrom: [ '15' ] )
-				modelLoadingInstructions appendTo: script on: canvas.
+			( ComponentValueSettingCommand
+				triggeringChangesObtainingIdentifierFrom: [ :theCanvas | input identifierOn: theCanvas ]
+				valueFrom: [ '15' ] ) modelLoadingInstructions appendTo: script on: canvas.
 			input script: ( canvas jQuery this onClick: script )
 			].
 
@@ -53,7 +56,7 @@ ComponentValueSettingCommandTest >> testModelLoadingActionsWithoutTriggering [
 			input := canvas textInput.
 			canvas ensureIdFor: input.
 			( ComponentValueSettingCommand
-				obtainingIdentifierFrom: [ input identifierOn: canvas ]
+				withoutTriggeringChangesObtainingIdentifierFrom: [ input identifierOn: canvas ]
 				valueFrom: [ '15' ] ) modelLoadingInstructions appendTo: script on: canvas.
 			input script: ( canvas jQuery this onClick: script )
 			].

source/Willow-Core-Tests/DateFieldWebViewTest.class.st

@@ -16,6 +16,19 @@ DateFieldWebViewTest >> changeNotifiedBy: aTextFieldWebView [
 	notificationWasReceived := true
 ]
 
+{ #category : #tests }
+DateFieldWebViewTest >> testBeIdentifiable [
+
+	| dateField html |
+
+	dateField := DateFieldWebView applying: [ :field |  ].
+
+	dateField beIdentifiable.
+	html := self render: dateField.
+
+	self assert: html equals: '<input value="" name="1" id="date-field-id2" type="date"/>'
+]
+
 { #category : #tests }
 DateFieldWebViewTest >> testDate [
 

source/Willow-Core-Tests/Html5ComponentSupplierTest.class.st

@@ -196,7 +196,7 @@ Html5ComponentSupplierTest >> testTableBuilderForHeadlessTable [
 	self
 		assert: html
 		equals:
-			'<table id="table-id1" class="fixed"><tbody><tr><td>1</td><td>2</td></tr><tr><td>2</td><td>3</td></tr><tr><td>3</td><td>4</td></tr></tbody></table>'
+			'<table class="fixed"><tbody><tr><td>1</td><td>2</td></tr><tr><td>2</td><td>3</td></tr><tr><td>3</td><td>4</td></tr></tbody></table>'
 ]
 
 { #category : #'tests-Supplying' }
@@ -225,7 +225,7 @@ Html5ComponentSupplierTest >> testTableBuilderWithFooter [
 	self
 		assert: html
 		equals:
-			'<table id="table-id1"><thead><th>Number</th><th>Even?</th></thead><tbody><tr><td>1</td><td>false</td></tr><tr><td>2</td><td>true</td></tr><tr><td>3</td><td>false</td></tr></tbody><tfoot><td></td><td>Fixed Footer</td></tfoot></table>'
+			'<table><thead><th>Number</th><th>Even?</th></thead><tbody><tr><td>1</td><td>false</td></tr><tr><td>2</td><td>true</td></tr><tr><td>3</td><td>false</td></tr></tbody><tfoot><td></td><td>Fixed Footer</td></tfoot></table>'
 ]
 
 { #category : #'tests-Supplying' }
@@ -237,7 +237,7 @@ Html5ComponentSupplierTest >> testTableBuilderWithRowCommand [
 
 	table := supplier tableBuilder
 		addColumn: [ :column | column rendering: [ :number | number ] ];
-		applyToEachRow: (PluggableTableRowCommand toExecute: [ :row :item :canvas | row id: canvas nextId ]);
+		applyToEachRow: ( PluggableTableRowCommand toExecute: [ :row :item :canvas | row id: canvas nextId ] );
 		build.
 
 	table changeContentsTo: #(1 2 3).
@@ -247,7 +247,7 @@ Html5ComponentSupplierTest >> testTableBuilderWithRowCommand [
 	self
 		assert: html
 		equals:
-			'<table id="table-id1"><tbody><tr id="id2"><td>1</td></tr><tr id="id3"><td>2</td></tr><tr id="id4"><td>3</td></tr></tbody></table>'
+			'<table><tbody><tr id="id1"><td>1</td></tr><tr id="id2"><td>2</td></tr><tr id="id3"><td>3</td></tr></tbody></table>'
 ]
 
 { #category : #'tests-Supplying' }
@@ -275,7 +275,7 @@ Html5ComponentSupplierTest >> testTableBuilderWithSimpleColumns [
 	self
 		assert: html
 		equals:
-			'<table id="table-id1"><thead><th>Number</th><th>Even?</th></thead><tbody><tr><td>1</td><td>false</td></tr><tr><td>2</td><td>true</td></tr><tr><td>3</td><td>false</td></tr></tbody></table>'
+			'<table><thead><th>Number</th><th>Even?</th></thead><tbody><tr><td>1</td><td>false</td></tr><tr><td>2</td><td>true</td></tr><tr><td>3</td><td>false</td></tr></tbody></table>'
 ]
 
 { #category : #'tests-Supplying' }

source/Willow-Core-Tests/MultipleSelectionListBoxWebViewTest.class.st

@@ -38,6 +38,21 @@ MultipleSelectionListBoxWebViewTest >> testAllowsAnySatisfying [
 		deny: (listBox allowsAnySatisfying: [ :element | element isZero ])
 ]
 
+{ #category : #'tests-configuring' }
+MultipleSelectionListBoxWebViewTest >> testBeIdentifiable [
+
+	| listBox html |
+
+	listBox := self newListBox.
+	listBox beIdentifiable.
+
+	html := self render: listBox.
+
+	self
+		assert: html
+		equals: '<select name="1" id="list-box-id2" multiple></select><input name="3" type="hidden"/>'
+]
+
 { #category : #'tests-Multiple Selection-API' }
 MultipleSelectionListBoxWebViewTest >> testChooseAll [
 
@@ -118,7 +133,7 @@ MultipleSelectionListBoxWebViewTest >> testChooseAllMatching [
 	self assert: listBox currentSelection equals: #(2 4)
 ]
 
-{ #category : #tests }
+{ #category : #'tests-configuring' }
 MultipleSelectionListBoxWebViewTest >> testIdentifierOn [
 
 	| listBox html |
@@ -185,7 +200,7 @@ MultipleSelectionListBoxWebViewTest >> testNotifyChangesWhenSelectionDoesNotChan
 		assert: listBox currentSelection isEmpty
 ]
 
-{ #category : #'tests-rendering' }
+{ #category : #'tests-configuring' }
 MultipleSelectionListBoxWebViewTest >> testOn [
 
 	| listBox html |

source/Willow-Core-Tests/NumberFieldWebViewTest.class.st

@@ -16,6 +16,19 @@ NumberFieldWebViewTest >> changeNotifiedBy: aTextFieldWebView [
 	notificationWasReceived := true
 ]
 
+{ #category : #'tests-configuring' }
+NumberFieldWebViewTest >> testBeIdentifiable [
+
+	| numberField html |
+
+	numberField := NumberFieldWebView applying: [ :field |  ] transformingWith: IntegerCodec new.
+
+	numberField beIdentifiable.
+	html := self render: numberField.
+
+	self assert: html equals: '<input value="" name="1" id="number-field-id2" type="number"/>'
+]
+
 { #category : #'tests-configuring' }
 NumberFieldWebViewTest >> testIdentifierOn [
 

source/Willow-Core-Tests/RadioGroupWebViewTest.class.st

@@ -3,7 +3,7 @@ A RadioGroupWebViewTest is a test class for testing the behavior of RadioGroupWe
 "
 Class {
 	#name : #RadioGroupWebViewTest,
-	#superclass : #SingleSelectionWebViewTest,
+	#superclass : #SingleSelectionWebViewBehaviorTest,
 	#category : #'Willow-Core-Tests-WebViews'
 }
 

source/Willow-Core-Tests/SingleSelectionWebViewAsDropDownListTest.class.st

@@ -3,7 +3,7 @@ A DropDownListWebViewTest is a test class for testing the behavior of DropDownLi
 "
 Class {
 	#name : #SingleSelectionWebViewAsDropDownListTest,
-	#superclass : #SingleSelectionWebViewTest,
+	#superclass : #SingleSelectionWebViewBehaviorTest,
 	#category : #'Willow-Core-Tests-WebViews'
 }
 
@@ -14,6 +14,19 @@ SingleSelectionWebViewAsDropDownListTest >> newSingleSelectionView [
 		applyingToOptions: [  ]
 ]
 
+{ #category : #'tests-configuring' }
+SingleSelectionWebViewAsDropDownListTest >> testBeIdentifiable [
+
+	| dropDownList html |
+
+	dropDownList := self newSingleSelectionView.
+	dropDownList beIdentifiable.
+
+	html := self render: dropDownList.
+
+	self assert: html equals: '<select name="1" id="single-select-id2"></select>'
+]
+
 { #category : #'tests-rendering' }
 SingleSelectionWebViewAsDropDownListTest >> testCustomCommandForOptions [
 	| dropDownList html |

source/Willow-Core-Tests/SingleSelectionWebViewAsListBoxTest.class.st

@@ -3,7 +3,7 @@ A SingleSelectionListBoxWebViewTest is a test class for testing the behavior of
 "
 Class {
 	#name : #SingleSelectionWebViewAsListBoxTest,
-	#superclass : #SingleSelectionWebViewTest,
+	#superclass : #SingleSelectionWebViewBehaviorTest,
 	#category : #'Willow-Core-Tests-WebViews'
 }
 
@@ -13,6 +13,19 @@ SingleSelectionWebViewAsListBoxTest >> newSingleSelectionView [
 	^ SingleSelectionWebView listBoxDisplayingAtOnce: 5
 ]
 
+{ #category : #tests }
+SingleSelectionWebViewAsListBoxTest >> testBeIdentifiable [
+
+	| listBox html |
+
+	listBox := self newSingleSelectionView.
+	listBox beIdentifiable.
+
+	html := self render: listBox.
+
+	self assert: html equals: '<select name="1" id="single-select-id2" size="5"></select>'
+]
+
 { #category : #'tests-rendering' }
 SingleSelectionWebViewAsListBoxTest >> testCustomCommandForOptions [
 	| dropDownList html |

source/Willow-Core-Tests/SingleSelectionWebViewTest.class.st → source/Willow-Core-Tests/SingleSelectionWebViewBehaviorTest.class.st

@@ -2,7 +2,7 @@
 I'm an abstract test case for views implementing the single selection API
 "
 Class {
-	#name : #SingleSelectionWebViewTest,
+	#name : #SingleSelectionWebViewBehaviorTest,
 	#superclass : #BWRenderingTest,
 	#instVars : [
 		'notificationWasReceived'
@@ -11,25 +11,25 @@ Class {
 }
 
 { #category : #testing }
-SingleSelectionWebViewTest class >> isAbstract [
+SingleSelectionWebViewBehaviorTest class >> isAbstract [
 
-	^self name = #SingleSelectionWebViewTest
+	^self name = #SingleSelectionWebViewBehaviorTest
 ]
 
 { #category : #support }
-SingleSelectionWebViewTest >> changeNotifiedBy: aDropDownListWebView [ 
+SingleSelectionWebViewBehaviorTest >> changeNotifiedBy: aDropDownListWebView [ 
 
 	notificationWasReceived := true
 ]
 
 { #category : #support }
-SingleSelectionWebViewTest >> newSingleSelectionView [
+SingleSelectionWebViewBehaviorTest >> newSingleSelectionView [
 
 	^self subclassResponsibility 
 ]
 
 { #category : #'tests-Single Selection-API' }
-SingleSelectionWebViewTest >> testAllowsAnySatisfying [
+SingleSelectionWebViewBehaviorTest >> testAllowsAnySatisfying [
 
 	| singleSelectionView |
 
@@ -45,7 +45,7 @@ SingleSelectionWebViewTest >> testAllowsAnySatisfying [
 ]
 
 { #category : #'tests-Single Selection-API' }
-SingleSelectionWebViewTest >> testChooseAny [
+SingleSelectionWebViewBehaviorTest >> testChooseAny [
 
 	| singleSelectionView allowedElements |
 
@@ -65,7 +65,7 @@ SingleSelectionWebViewTest >> testChooseAny [
 ]
 
 { #category : #'tests-Single Selection-API' }
-SingleSelectionWebViewTest >> testChooseEqualTo [
+SingleSelectionWebViewBehaviorTest >> testChooseEqualTo [
 
 	| singleSelectionView allowedElements |
 
@@ -89,7 +89,7 @@ SingleSelectionWebViewTest >> testChooseEqualTo [
 ]
 
 { #category : #'tests-Single Selection-API' }
-SingleSelectionWebViewTest >> testNotifyChangesTo [
+SingleSelectionWebViewBehaviorTest >> testNotifyChangesTo [
 
 	| singleSelectionView |
 
@@ -103,7 +103,7 @@ SingleSelectionWebViewTest >> testNotifyChangesTo [
 ]
 
 { #category : #'tests-Single Selection-API' }
-SingleSelectionWebViewTest >> testNotifyChangesWhenAvailableElementsChangeButContainsTheSelectedOne [
+SingleSelectionWebViewBehaviorTest >> testNotifyChangesWhenAvailableElementsChangeButContainsTheSelectedOne [
 
 	| singleSelectionView |
 
@@ -124,7 +124,7 @@ SingleSelectionWebViewTest >> testNotifyChangesWhenAvailableElementsChangeButCon
 ]
 
 { #category : #'tests-Single Selection-API' }
-SingleSelectionWebViewTest >> testNotifyChangesWhenAvailableElementsChangeButDoesNotContainTheSelectedOne [
+SingleSelectionWebViewBehaviorTest >> testNotifyChangesWhenAvailableElementsChangeButDoesNotContainTheSelectedOne [
 
 	| singleSelectionView |
 
@@ -146,7 +146,7 @@ SingleSelectionWebViewTest >> testNotifyChangesWhenAvailableElementsChangeButDoe
 ]
 
 { #category : #'tests-Single Selection-API' }
-SingleSelectionWebViewTest >> testNotifyChangesWhenSelectionChanged [
+SingleSelectionWebViewBehaviorTest >> testNotifyChangesWhenSelectionChanged [
 
 	| singleSelectionView |
 
@@ -163,7 +163,7 @@ SingleSelectionWebViewTest >> testNotifyChangesWhenSelectionChanged [
 ]
 
 { #category : #'tests-Single Selection-API' }
-SingleSelectionWebViewTest >> testNotifyChangesWhenSelectionDoesNotChange [
+SingleSelectionWebViewBehaviorTest >> testNotifyChangesWhenSelectionDoesNotChange [
 
 	| singleSelectionView |
 
@@ -181,7 +181,7 @@ SingleSelectionWebViewTest >> testNotifyChangesWhenSelectionDoesNotChange [
 ]
 
 { #category : #'tests-Single Selection-API' }
-SingleSelectionWebViewTest >> testWithCurrentSelectionDo [
+SingleSelectionWebViewBehaviorTest >> testWithCurrentSelectionDo [
 
 	| singleSelectionView allowedElements |