-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial support for localization and internationalization #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add String>>#escaped and String>>#unescaped to handle character control and Unicode escape sequences
Add CurrentLocale dynamic variable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-candidate #126 +/- ##
====================================================
Coverage 100.00% 100.00%
====================================================
Files 81 95 +14
Lines 7383 8318 +935
====================================================
+ Hits 7383 8318 +935
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5 tasks
mtabacman
requested changes
Jun 22, 2024
source/Buoy-Localization-GS64-Extensions/CharacterCollection.extension.st
Show resolved
Hide resolved
source/Buoy-Localization-GS64-Extensions/CharacterCollection.extension.st
Outdated
Show resolved
Hide resolved
source/Buoy-Localization-GS64-Extensions/NaturalLanguageTranslator.class.st
Outdated
Show resolved
Hide resolved
mtabacman
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LanguageRange
andLanguageTag
abstractions from Hyperspace to be used in the localization supportString>>unescaped
transforms the escaping sequences into the target Unicode charactersString>>escaped
is a kind of inverse but some sequences have several possible escaping optionsCurrentLocale
dynamic variable to control the localization optionsString>>localized
andString>>localizedWithAll:
providing translation services dependent on the current locale for the process, placeholders between{}
are interpolated with the provided arguments, and escaping sequences are automatically unescaped.TestCase
to ease the testing of locale-aware codeThis is the first milestone, in the future we will be adding
localized
methods for Numbers, Chronology objects, and pluralization rules as needed.