Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bkushigian/issue14 Serialize Tree/Card Configurations #50

Closed

Conversation

bkushigian
Copy link
Contributor

Saving/loading tree/card configurations should be easy. The following data needs to be present when running a solve:

  • CardConfig: contains
    • ranges (OOP and IP)
    • flop cards
    • turn card
    • river card
  • TreeConfig: used to build an ActionTree, this contains:
    • initial_state: BoardState
    • starting_pot
    • effective_stack
    • rake info
    • flop_bet_sizes
    • turn_bet_sizes
    • river_bet_sizes
    • turn_donk_sizes
    • river_bet_sizes
    • add_allin_threshold
    • force_allin_threshold
    • merging_threshold

A couple things to think about:

  1. Data Duplication: card_config's flop/turn/river determine tree_config's initial_state value, and this might be annoying for a user to fill out/can lead to buggy configurations.
  2. Sometimes, as in the case of a batch solve where we run over many different boards, the flop/turn/river cards aren't known in the configuration.
  • Pio handles this by just specifying dummy cards and then having the batch solve module accept a set of flops separately.

For now, having an easy way to load/save configs and use to solve sets of flops will be very useful

@bkushigian
Copy link
Contributor Author

jfc github will NOT stop sending PRs to this repo. This has been a bug in github for years. Closing

@bkushigian bkushigian closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant