Add error handling to discovery host #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the setup for a single socket fails, the whole initialization process is aborted. The exception is never handled and might therefore take down the whole application. This fix logs the exception for the single socket and continues with the next socket rather than aborting the initialization on failure.
Replaces the nuget binary with a newer version that supports C# 6 syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the socket options in the DiscoveryHost class fails on some system configurations. The failure triggers a SocketException as described in issue #8. A first step to address this problem has been made by making the client discovery optional. Still, if you want to use the client discovery, you risk running into the above mentioned exception which will effectively take down the whole application.
This PR adds a little error handling which logs the failed address and the exception. If the error occurrs, the failed address is ignored and the initialization will resume with the next address. Logging more information about this problem is essential since it might give some insight in what actually causes the crash. That might give us enough information to eventually fix the filter and avoid the exception in the first place.
This PR also updates the NuGet binary to version 4.3.0 in order to support C# 6 language features.