[WIP] Filterx docs #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fekete-robert
force-pushed
the
filterx-draft
branch
from
f191d34
to
200f4a9
Compare
orymate
reviewed
Aug 15, 2024
Co-authored-by: Máté Őry <[email protected]>
Co-authored-by: Máté Őry <[email protected]>
Co-authored-by: Máté Őry <[email protected]>
Co-authored-by: Máté Őry <[email protected]>
furiel
reviewed
Aug 26, 2024
furiel
reviewed
Aug 26, 2024
furiel
reviewed
Aug 26, 2024
furiel
reviewed
Aug 26, 2024
alltilla
reviewed
Sep 10, 2024
alltilla
reviewed
Sep 11, 2024
Comment on lines
+126
to
+135
| | Numerical or string operator | String operator | Meaning | | ||
| | ------------------ | --------------- | --------------------- | | ||
| | == | eq | Equals | | ||
| | != | ne | Not equal to | | ||
| | > | gt | Greater than | | ||
| | < | lt | Less than | | ||
| | >= | ge | Greater than or equal | | ||
| | =< | le | Less than or equal | | ||
| | === | | Equals and has the same type | | ||
| | !== | | Not equal to or has different type | |
There was a problem hiding this comment.
The string operators are introduced here, and I don't know if it is understandable for the reader just by this name. I think it is worth a smaller section.
alltilla
reviewed
Sep 12, 2024
alltilla
reviewed
Sep 12, 2024
|
|
||
| If the object doesn't exist, `istype()` returns with an error, causing the filterx statement to become false, and logs an error message to the `internal()` source of {{< product >}}. | ||
|
|
||
| ## json, json_object {#json} |
There was a problem hiding this comment.
Suggested change
| ## json, json_object {#json} | |
| ## json {#json} |
|
Done with my first full review round :) Looks really good so far, good job! |
alltilla
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.