Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make RECEIPT_HOME variable XDG compliant #1355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brennanfee
Copy link
Contributor

The setting of RECEIPT_HOME using "${HOME}/.config" will fail for users who move their config folder elsewhere using XDG_CONFIG_HOME. Both dash and bash (the usual interpreters for /bin/sh) both support parameter substitution.

The setting of RECEIPT_HOME using "${HOME}/.config" will fail for users
who move their config folder elsewhere using XDG_CONFIG_HOME. Both dash
and bash (the usual interpreters for /bin/sh) both support parameter
substitution.
@Gankra
Copy link
Contributor

Gankra commented Aug 22, 2024

(failures are just needing to run cargo test, cargo insta review --accept, i can do that for you)

Copy link
Contributor

@Gankra Gankra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh rad, ty. We might need to port this to axoupdater as well to make sure everything that cares about receipts agrees and can reliably find this.

Hmm, also actually now that I think about this there's a bit of a migration concern... ok right I think migration handling can just exist in axoupdater. The install script itself is write-only, so doesn't need to care if it changes location.

@Gankra
Copy link
Contributor

Gankra commented Aug 22, 2024

Oh haha, because this PR is from the main branch of your fork I'm not actually allowed to push to it 😅

@brennanfee
Copy link
Contributor Author

I can move this to another branch, but I believe I would need to re-submit a PR? I don't think we can edit the branch the PR comes from. What would be your preference?

@brennanfee
Copy link
Contributor Author

brennanfee commented Aug 24, 2024

Also, I'd be happy to take a look at axoupdater. I have a lot of bash scripting experience and can spot XDG "errors" like a hawk. However, I'm new to rust so will need a fair bit of support from you guys to make sure I'm not messing something up.

@Gankra
Copy link
Contributor

Gankra commented Sep 4, 2024

Sorry for the delay this PR is great and is approved but had some interesting logistics.

So what needs to happen is:

@Gankra
Copy link
Contributor

Gankra commented Sep 4, 2024

For "don't count your chickens before they hatch" reasons ideally we impl #1392 before we merge/release axoupdater.

@ashleygwilliams
Copy link
Member

now that #1392 is merged we are closer to getting this merged. the current plan is to release this is the release after next (which will contain the minimum viable version work)

mistydemeo added a commit to axodotdev/axoupdater that referenced this pull request Oct 9, 2024
mistydemeo added a commit to axodotdev/axoupdater that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants