clean up/Javadoc

axkr · Sep 25, 2024 · ff2a511 · ff2a511
1 parent c039d2c
commit ff2a511
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/...library/matheclipse-core/src/main/java/org/matheclipse/core/builtin/IntegerFunctions.java b/...library/matheclipse-core/src/main/java/org/matheclipse/core/builtin/IntegerFunctions.java
@@ -8,7 +8,6 @@
 import org.apfloat.Apfloat;
 import org.hipparchus.complex.Complex;
 import org.matheclipse.core.basic.Config;
-import org.matheclipse.core.basic.OperationSystem;
 import org.matheclipse.core.eval.Errors;
 import org.matheclipse.core.eval.EvalEngine;
 import org.matheclipse.core.eval.exception.ASTElementLimitExceeded;

diff --git a/symja_android_library/matheclipse-core/src/main/java/org/matheclipse/core/expression/F.java b/symja_android_library/matheclipse-core/src/main/java/org/matheclipse/core/expression/F.java
@@ -39,7 +39,6 @@
 import org.hipparchus.fraction.BigFraction;
 import org.matheclipse.core.basic.AndroidLoggerFix;
 import org.matheclipse.core.basic.Config;
-import org.matheclipse.core.basic.OperationSystem;
 import org.matheclipse.core.builtin.Algebra;
 import org.matheclipse.core.builtin.Arithmetic;
 import org.matheclipse.core.builtin.AssociationFunctions;
@@ -2853,7 +2852,7 @@ public static INumber chopNumber(INumber arg, double delta) {
           return F.complexNum(Apfloat.ZERO, imag);
         }
       } else {
-        Complex c = ((IComplexNum) arg).evalfc();
+        Complex c = arg.evalfc();
         if (isZero(c.getReal(), delta)) {
           if (isZero(c.getImaginary(), delta)) {
             return C0;
@@ -4451,8 +4450,9 @@ public static IAST Fibonacci(final IExpr a0, final IExpr a1) {
     return new AST2(Fibonacci, a0, a1);
   }
 
-  public static IAST FindFit(final IExpr a0, final IExpr a1, final IExpr a2, final IExpr a3) {
-    return quaternary(FindFit, a0, a1, a2, a3);
+  public static IAST FindFit(final IExpr data, final IExpr expr, final IExpr variablesList,
+      final IExpr xVariable) {
+    return quaternary(FindFit, data, expr, variablesList, xVariable);
   }
 
   public static IAST FindFormula(final IExpr data, final IExpr x) {

diff --git a/..._library/matheclipse-core/src/main/java/org/matheclipse/core/graphics/Show3D2ThreeJS.java b/..._library/matheclipse-core/src/main/java/org/matheclipse/core/graphics/Show3D2ThreeJS.java
@@ -158,7 +158,7 @@ static void elements(String type, IAST ast, StringBuilder buf, Dimensions2D dim)
             buf.append("}], ");
           }
         }
-      } else if (arg1.isList() && ((IAST) arg1).isAST3()) {
+      } else if (arg1.isList() && arg1.isAST3()) {
         try {
           buf.append("\"elements\": [{\"coords\": [");
           addCoordsToElements(buf, ((IAST) arg1));

diff --git a/...ibrary/matheclipse-core/src/main/java/org/matheclipse/core/patternmatching/RulesData.java b/...ibrary/matheclipse-core/src/main/java/org/matheclipse/core/patternmatching/RulesData.java
@@ -98,7 +98,7 @@ private static boolean isComplicatedPatternExpr(IExpr a1) {
 
   private Map<IExpr, PatternMatcherEquals> fEqualDownRules;
 
-  private IMatch fMatcher;
+  private transient IMatch fMatcher;
 
   /**
    * List of pattern matchers. The corresponding priority is stored in <code>fPriorityDownRules

diff --git a/...brary/matheclipse-core/src/test/java/org/matheclipse/core/system/StringFunctionsTest.java b/...brary/matheclipse-core/src/test/java/org/matheclipse/core/system/StringFunctionsTest.java
@@ -585,6 +585,9 @@ public void testStringRepeat() {
 
    @Test
    public void testStringReplace() {
+     // TODO use MMA logic for lists of rules
+     // check("StringReplace(\"ABBA\", {\"A\" -> \"AB\", \"B\" -> \"BA\"})", //
+     // "ABBABAAB ");
     check(
         "StringReplace(\"The number 17 is a prime number, 42 is not\", WordBoundary ~~ x:DigitCharacter.. ~~ WordBoundary /; PrimeQ(ToExpression(x)) :> \"*\" <> x <> \"*\")", //
         "The number *17* is a prime number, 42 is not");