Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel #44

Merged
merged 17 commits into from
Mar 10, 2024
Merged

Parallel #44

merged 17 commits into from
Mar 10, 2024

Conversation

axionbuster
Copy link
Owner

@axionbuster axionbuster commented Mar 10, 2024

  • Enable compiling and running with OpenMP support on Windows.
  • Enable compiling and running with OpenMP support on macOS and Ubuntu Linux.
  • Test compilation and running on stock macOS.
  • Test compilation and running on stock Ubuntu.
  • Test compilation and running on stock Windows.

When a particle's circle is overlapping with a group's circle.

Term:
- Group: A bunch of particles can be summarized as a "group" of particles which is a giant circle that contains the smaller particles. Control of level of detail for long-distance force computations.

Context:
- The net force onto a particle due to a group (of particles) is being computed.
- The particle's circle is both large and close enough to the group's circle: Overlapping.
- Retract the approximation and resolve more detail.
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (24dee58) to head (082b0d5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files          10       10           
  Lines         214      214           
=======================================
  Hits          210      210           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The problem is that it's burning all my CPU (probably starting a team of threads every frame).
@axionbuster
Copy link
Owner Author

On Windows, the spinning problem was solved by simply supplying the environment variable OMP_WAIT_POLICY to disable spinlocks:

$Env:OMP_WAIT_POLICY = "PASSIVE"

@axionbuster axionbuster merged commit 812eb67 into master Mar 10, 2024
13 checks passed
@axionbuster axionbuster deleted the parallel branch March 10, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant