Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deployment scripts #39

Merged
merged 3 commits into from
Aug 27, 2024
Merged

chore: update deployment scripts #39

merged 3 commits into from
Aug 27, 2024

Conversation

PangZhi
Copy link
Contributor

@PangZhi PangZhi commented Aug 26, 2024

this PR checks in the verifier contracts for different sizes, and update the deployment scripts to use the correct verifier

@PangZhi PangZhi requested review from yi-sun and HrikB August 26, 2024 22:18
Copy link
Contributor

@HrikB HrikB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run forge fmt? (Also would be great if you could add it to CI with forge fmt --check)

// uint256 transferAmount = 100_000 * 10 ** 18;
// wldTokenContract.transfer(address(worldcoinAggV2), transferAmount);
IERC20 wldTokenContract = IERC20(wldToken);
uint256 transferAmount = 100_000 * 10 ** 18;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could be easier to write 100_000e18

@PangZhi PangZhi merged commit 95df34a into main Aug 27, 2024
3 checks passed
@PangZhi PangZhi deleted the jf/contract_deployment branch August 27, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants