Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generic circuits, signal_hash = receiver, per claim grant_id, refactors #35

Merged
merged 17 commits into from
Aug 24, 2024
Merged

feat: generic circuits, signal_hash = receiver, per claim grant_id, refactors #35

merged 17 commits into from
Aug 24, 2024

Conversation

PangZhi
Copy link
Contributor

@PangZhi PangZhi commented Aug 22, 2024 •
edited
Loading

  • use receiver as signal_hash
  • have per claim grant_id, and update public outputs
  • refactor scheduler and circuits to reduce redundancy code
  • check-in newly generated testing data with the signal_hash and grant_id change

yi-sun
yi-sun requested changes Aug 23, 2024
View reviewed changes
standalone_circuit/README.md Outdated Show resolved Hide resolved
standalone_circuit/README.md Outdated Show resolved Hide resolved
standalone_circuit/README.md Outdated Show resolved Hide resolved
standalone_circuit/README.md Outdated Show resolved Hide resolved
standalone_circuit/src/circuits/v1/intermediate.rs Outdated Show resolved Hide resolved
standalone_circuit/src/circuits/v1/leaf.rs Outdated Show resolved Hide resolved
standalone_circuit/src/circuits/v2/leaf.rs Outdated Show resolved Hide resolved
@PangZhi PangZhi requested a review from yi-sun August 23, 2024 16:07
jonathanpwang
jonathanpwang approved these changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

The only functionality change of circuits is as described in PR: per-claim grant_id and replacing signal_hash with receiver.

Otherwise this PR is mostly improving code quality by removing some duplicate code both in the circuit join_instance functions and in the backend scheduler.

@jonathanpwang jonathanpwang mentioned this pull request Aug 24, 2024
Merged
2 tasks
@PangZhi
Copy link
Contributor Author

PangZhi commented Aug 24, 2024

addressed the remaining comments

@PangZhi
Copy link
Contributor Author

PangZhi commented Aug 24, 2024

@yi-sun i'm not sure what's blocking merging the request

@yi-sun
Copy link
Contributor

yi-sun commented Aug 24, 2024

Nothing blocking on my side, I think it's OK to merge.

@PangZhi PangZhi merged commit 1ba7e6b into main Aug 24, 2024
3 checks passed
@PangZhi PangZhi deleted the jf/generic_circuits branch August 24, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

@yi-sun yi-sun yi-sun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PangZhi @yi-sun @jonathanpwang