[Release v0.4.0] FFT memory reduction and proving key size reduction (#…

…17)

* Resolve Prover optimization: memory reduction privacy-scaling-explorations#77 (#6)

* Resolve taikoxyz/zkevm-circuits#77

* Please Clippy

* fix: recursive FFT for lengths not `2^k, 2^extended_k`

Also fixed some issue when multicore feature is not on.

* fix: evaluation (cherry-pick
https://github.com/scroll-tech/halo2-gpu/blob/a3019b047ad7d7119103f4d9df3fd33ce1429f95/halo2_proofs/src/plonk/evaluation.rs)

* fix: `g_to_lagrange` uses inverse fft

* Bump version since this is a breaking change to pk

* chore: update halo2curves version

---------

Co-authored-by: einar-taiko <[email protected]>

.github/workflows/ci.yml

@@ -31,9 +31,9 @@ jobs:
         with:
           override: false
       - name: Run examples
-        run: cargo run --example serialization
+        run: |
+          cargo run --example serialization
           cargo run --example shuffle
-          cargo run --example shuffle_api
 
   fmt:
     name: Rustfmt

halo2_proofs/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "halo2-axiom"
-version = "0.3.1"
+version = "0.4.0"
 authors = [
     "Sean Bowe <[email protected]>",
     "Ying Tong Lai <[email protected]>",
@@ -55,12 +55,13 @@ name = "fft"
 harness = false
 
 [dependencies]
+itertools = "0.11"
 backtrace = { version = "0.3", optional = true }
 crossbeam = "0.8"
 ff = "0.13"
 group = "0.13"
 pairing = "0.23"
-halo2curves = { package = "halo2curves-axiom", version = "0.4.1", default-features = false, features = ["bits", "bn256-table", "derive_serde"] }
+halo2curves = { package = "halo2curves-axiom", version = "0.4.2", default-features = false, features = ["bits", "bn256-table", "derive_serde"] }
 rand = "0.8"
 rand_core = { version = "0.6", default-features = false}
 tracing = "0.1"
@@ -84,6 +85,7 @@ gumdrop = "0.8"
 proptest = "1"
 rand_core = { version = "0.6", features = ["getrandom"] }
 rand_chacha = "0.3.1"
+ark-std = { version = "0.3.0", features = ["print-trace"] }
 
 [target.'cfg(all(target_arch = "wasm32", target_os = "unknown"))'.dev-dependencies]
 getrandom = { version = "0.2", features = ["js"] }
@@ -114,6 +116,3 @@ name = "serialization"
 
 [[example]]
 name = "shuffle"
-
-[[example]]
-name = "shuffle_api"

halo2_proofs/benches/fft.rs

@@ -3,20 +3,28 @@ extern crate criterion;
 
 use crate::arithmetic::best_fft;
 use group::ff::Field;
-use halo2_axiom::*;
-use halo2curves::pasta::Fp;
+use halo2_axiom::{poly::EvaluationDomain, *};
+use halo2curves::bn256::Fr as Scalar;
 
 use criterion::{BenchmarkId, Criterion};
 use rand_core::OsRng;
 
 fn criterion_benchmark(c: &mut Criterion) {
+    let j = 5;
     let mut group = c.benchmark_group("fft");
     for k in 3..19 {
+        let domain = EvaluationDomain::new(j, k);
+        let omega = domain.get_omega();
+        let l = 1 << k;
+        let data = domain.get_fft_data(l);
+
         group.bench_function(BenchmarkId::new("k", k), |b| {
-            let mut a = (0..(1 << k)).map(|_| Fp::random(OsRng)).collect::<Vec<_>>();
-            let omega = Fp::random(OsRng); // would be weird if this mattered
+            let mut a = (0..(1 << k))
+                .map(|_| Scalar::random(OsRng))
+                .collect::<Vec<_>>();
+
             b.iter(|| {
-                best_fft(&mut a, omega, k as u32);
+                best_fft(&mut a, omega, k, data, false);
             });
         });
     }