warning: accessing first element with `slice.get(0)` --> halo2_proofs/src/helpers.rs:146:40 | 146 | 4 + slice.len() * (4 + field_len * slice.get(0).map(|poly| poly.len()).unwrap_or(0)) | ^^^^^^^^^^^^ help: try: `slice.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first

warning: doc list item without indentation --> halo2_proofs/src/helpers.rs:86:9 | 86 | /// WITHOUT performing the expensive Montgomery reduction. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 86 | /// WITHOUT performing the expensive Montgomery reduction. | ++

warning: doc list item without indentation --> halo2_proofs/src/helpers.rs:84:9 | 84 | /// `PrimeField` implementation. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 84 | /// `PrimeField` implementation. | ++

warning: doc list item without indentation --> halo2_proofs/src/helpers.rs:66:9 | 66 | /// and checks that the element is less than the modulus. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 66 | /// and checks that the element is less than the modulus. | ++

warning: doc list item without indentation --> halo2_proofs/src/helpers.rs:64:9 | 64 | /// `PrimeField` implementation, and checks that the element is less than the modulus. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 64 | /// `PrimeField` implementation, and checks that the element is less than the modulus. | ++

warning: doc list item without indentation --> halo2_proofs/src/helpers.rs:41:9 | 41 | /// does not perform any checks | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 41 | /// does not perform any checks | ++

warning: doc list item without indentation --> halo2_proofs/src/helpers.rs:39:9 | 39 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 39 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve. | ++

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:1312:41 | 1312 | / ... &util::load_instance( 1313 | | ... n, 1314 | | ... row, 1315 | | ... &self.cs.instance_queries, 1316 | | ... &self.instance, 1317 | | ... ), | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args help: change this to | 1312 ~ util::load_instance( 1313 + n, 1314 + row, 1315 + &self.cs.instance_queries, 1316 + &self.instance, 1317 ~ ), |

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:1311:41 | 1311 | ... &util::load(n, row, &self.cs.advice_queries, advice), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.advice_queries, advice)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:1310:41 | 1310 | ... &util::load(n, row, &self.cs.fixed_queries, &self.fixed), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.fixed_queries, &self.fixed)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:900:41 | 900 | / ... &util::load_instance( 901 | | ... n, 902 | | ... row, 903 | | ... &self.cs.instance_queries, 904 | | ... &self.instance, 905 | | ... ), | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args help: change this to | 900 ~ util::load_instance( 901 + n, 902 + row, 903 + &self.cs.instance_queries, 904 + &self.instance, 905 ~ ), |

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:899:41 | 899 | ... &util::load(n, row, &self.cs.advice_queries, advice), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.advice_queries, advice)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:898:41 | 898 | ... &util::load(n, row, &self.cs.fixed_queries, &self.fixed), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.fixed_queries, &self.fixed)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: this bound is already specified as the supertrait of `ExactSizeIterator` --> halo2_proofs/src/poly.rs:256:26 | 256 | inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls = note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]` help: try removing this bound | 256 - inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, 256 + inv_denoms: impl ExactSizeIterator<Item = F>, |

warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> halo2_proofs/src/poly/domain.rs:605:28 | 605 | fn fft_inner(&self, a: &mut Vec<F>, omega: F, log_n: u32, inverse: bool) { | ^^^^^^^^^^^ help: change this to: `&mut [F]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> halo2_proofs/src/poly/domain.rs:593:23 | 593 | fn ifft(&self, a: &mut Vec<F>, omega_inv: F, log_n: u32, divisor: F) { | ^^^^^^^^^^^ help: change this to: `&mut [F]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `-W clippy::ptr-arg` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::ptr_arg)]`

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:382:9 | 382 | /// does not perform any checks | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 382 | /// does not perform any checks | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:380:9 | 380 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 380 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:378:9 | 378 | /// `PrimeField` implementation, and checks that the element is less than the modulus. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 378 | /// `PrimeField` implementation, and checks that the element is less than the modulus. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:377:9 | 377 | /// Reads a field element in standard form, with endianness specified by the | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 377 | /// Reads a field element in standard form, with endianness specified by the | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:360:9 | 360 | /// Does so by first writing the verifying key and then serializing the rest of the data (in the form of field polynomials) | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 360 | /// Does so by first writing the verifying key and then serializing the rest of the data (in the form of field polynomials) | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:359:9 | 359 | /// WITHOUT performing the expensive Montgomery reduction. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 359 | /// WITHOUT performing the expensive Montgomery reduction. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:358:9 | 358 | /// Writes a field element into raw bytes in its internal Montgomery representation, | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 358 | /// Writes a field element into raw bytes in its internal Montgomery representation, | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:356:9 | 356 | /// `PrimeField` implementation. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 356 | /// `PrimeField` implementation. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:355:9 | 355 | /// Writes a field element in standard form, with endianness specified by the | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 355 | /// Writes a field element in standard form, with endianness specified by the | ++

warning: accessing first element with `self .selectors.get(0)` --> halo2_proofs/src/plonk.rs:207:20 | 207 | * (self | ____________________^ 208 | | .selectors 209 | | .get(0) | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `-W clippy::get-first` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::get_first)]` help: try | 207 ~ * (self 208 + .selectors.first() |

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:107:9 | 107 | /// does not perform any checks | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 107 | /// does not perform any checks | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:105:9 | 105 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 105 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:103:9 | 103 | /// `PrimeField` implementation, and checks that the element is less than the modulus. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 103 | /// `PrimeField` implementation, and checks that the element is less than the modulus. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:102:9 | 102 | /// Reads a field element in standard form, with endianness specified by the | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 102 | /// Reads a field element in standard form, with endianness specified by the | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:73:9 | 73 | /// WITHOUT performing the expensive Montgomery reduction. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 73 | /// WITHOUT performing the expensive Montgomery reduction. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:72:9 | 72 | /// Writes a field element into raw bytes in its internal Montgomery representation, | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 72 | /// Writes a field element into raw bytes in its internal Montgomery representation, | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:70:9 | 70 | /// `PrimeField` implementation. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 70 | /// `PrimeField` implementation. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:69:9 | 69 | /// Writes a field element in standard form, with endianness specified by the | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 69 | /// Writes a field element in standard form, with endianness specified by the | ++

warning: struct `Variable` is never constructed --> halo2_proofs/benches/plonk.rs:32:16 | 32 | pub struct Variable(Column<Advice>, usize); | ^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/prover.rs:342:42 | 342 | .map(|_| Blind(F::random(&mut self.rng))) | ^^^^^^^^^^^^^ help: change this to: `self.rng` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/prover.rs:336:39 | 336 | *cell = F::random(&mut self.rng); | ^^^^^^^^^^^^^ help: change this to: `self.rng` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: you seem to use `.enumerate()` and immediately discard the index --> halo2_proofs/examples/shuffle.rs:169:50 | 169 | for (_idx, (&column, values)) in config | __________________________________________________^ 170 | | .shuffled 171 | | .iter() 172 | | .zip(self.shuffled.transpose_array().iter()) 173 | | .enumerate() | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index help: remove the `.enumerate()` call | 169 ~ for (&column, values) in config 170 + .shuffled 171 + .iter() 172 + .zip(self.shuffled.transpose_array().iter()) |

warning: you seem to use `.enumerate()` and immediately discard the index --> halo2_proofs/examples/shuffle.rs:159:50 | 159 | for (_idx, (&column, values)) in config | __________________________________________________^ 160 | | .original 161 | | .iter() 162 | | .zip(self.original.transpose_array().iter()) 163 | | .enumerate() | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index = note: `-W clippy::unused-enumerate-index` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unused_enumerate_index)]` help: remove the `.enumerate()` call | 159 ~ for (&column, values) in config 160 + .original 161 + .iter() 162 + .zip(self.original.transpose_array().iter()) |

warning: doc list item without indentation --> halo2_proofs/src/plonk/lookup/prover.rs:566:5 | 566 | /// This method returns (A', S') if no errors are encountered. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 566 | /// This method returns (A', S') if no errors are encountered. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk/lookup/prover.rs:402:5 | 402 | /// This method returns (A', S') if no errors are encountered. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 402 | /// This method returns (A', S') if no errors are encountered. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk/lookup/prover.rs:73:9 | 73 | /// The Permuted<C> struct is used to update the Lookup, and is then returned. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `-W clippy::doc-lazy-continuation` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::doc_lazy_continuation)]` help: indent this line | 73 | /// The Permuted<C> struct is used to update the Lookup, and is then returned. | ++

warning: accessing first element with `slice.get(0)` --> halo2_proofs/src/helpers.rs:146:40 | 146 | 4 + slice.len() * (4 + field_len * slice.get(0).map(|poly| poly.len()).unwrap_or(0)) | ^^^^^^^^^^^^ help: try: `slice.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first

warning: doc list item without indentation --> halo2_proofs/src/helpers.rs:86:9 | 86 | /// WITHOUT performing the expensive Montgomery reduction. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 86 | /// WITHOUT performing the expensive Montgomery reduction. | ++

warning: doc list item without indentation --> halo2_proofs/src/helpers.rs:84:9 | 84 | /// `PrimeField` implementation. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 84 | /// `PrimeField` implementation. | ++

warning: doc list item without indentation --> halo2_proofs/src/helpers.rs:66:9 | 66 | /// and checks that the element is less than the modulus. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 66 | /// and checks that the element is less than the modulus. | ++

warning: doc list item without indentation --> halo2_proofs/src/helpers.rs:64:9 | 64 | /// `PrimeField` implementation, and checks that the element is less than the modulus. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 64 | /// `PrimeField` implementation, and checks that the element is less than the modulus. | ++

warning: doc list item without indentation --> halo2_proofs/src/helpers.rs:41:9 | 41 | /// does not perform any checks | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 41 | /// does not perform any checks | ++

warning: doc list item without indentation --> halo2_proofs/src/helpers.rs:39:9 | 39 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 39 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve. | ++

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:1312:41 | 1312 | / ... &util::load_instance( 1313 | | ... n, 1314 | | ... row, 1315 | | ... &self.cs.instance_queries, 1316 | | ... &self.instance, 1317 | | ... ), | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args help: change this to | 1312 ~ util::load_instance( 1313 + n, 1314 + row, 1315 + &self.cs.instance_queries, 1316 + &self.instance, 1317 ~ ), |

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:1311:41 | 1311 | ... &util::load(n, row, &self.cs.advice_queries, advice), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.advice_queries, advice)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:1310:41 | 1310 | ... &util::load(n, row, &self.cs.fixed_queries, &self.fixed), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.fixed_queries, &self.fixed)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:900:41 | 900 | / ... &util::load_instance( 901 | | ... n, 902 | | ... row, 903 | | ... &self.cs.instance_queries, 904 | | ... &self.instance, 905 | | ... ), | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args help: change this to | 900 ~ util::load_instance( 901 + n, 902 + row, 903 + &self.cs.instance_queries, 904 + &self.instance, 905 ~ ), |

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:899:41 | 899 | ... &util::load(n, row, &self.cs.advice_queries, advice), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.advice_queries, advice)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev.rs:898:41 | 898 | ... &util::load(n, row, &self.cs.fixed_queries, &self.fixed), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.fixed_queries, &self.fixed)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: this bound is already specified as the supertrait of `ExactSizeIterator` --> halo2_proofs/src/poly.rs:256:26 | 256 | inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, | ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls = note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]` help: try removing this bound | 256 - inv_denoms: impl Iterator<Item = F> + ExactSizeIterator, 256 + inv_denoms: impl ExactSizeIterator<Item = F>, |

warning: struct `PointIndex` is never constructed --> halo2_proofs/src/plonk/circuit.rs:1422:19 | 1422 | pub(crate) struct PointIndex(pub usize); | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> halo2_proofs/src/poly/domain.rs:605:28 | 605 | fn fft_inner(&self, a: &mut Vec<F>, omega: F, log_n: u32, inverse: bool) { | ^^^^^^^^^^^ help: change this to: `&mut [F]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do --> halo2_proofs/src/poly/domain.rs:593:23 | 593 | fn ifft(&self, a: &mut Vec<F>, omega_inv: F, log_n: u32, divisor: F) { | ^^^^^^^^^^^ help: change this to: `&mut [F]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `-W clippy::ptr-arg` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::ptr_arg)]`

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:382:9 | 382 | /// does not perform any checks | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 382 | /// does not perform any checks | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:380:9 | 380 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 380 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:378:9 | 378 | /// `PrimeField` implementation, and checks that the element is less than the modulus. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 378 | /// `PrimeField` implementation, and checks that the element is less than the modulus. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:377:9 | 377 | /// Reads a field element in standard form, with endianness specified by the | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 377 | /// Reads a field element in standard form, with endianness specified by the | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:360:9 | 360 | /// Does so by first writing the verifying key and then serializing the rest of the data (in the form of field polynomials) | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 360 | /// Does so by first writing the verifying key and then serializing the rest of the data (in the form of field polynomials) | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:359:9 | 359 | /// WITHOUT performing the expensive Montgomery reduction. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 359 | /// WITHOUT performing the expensive Montgomery reduction. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:358:9 | 358 | /// Writes a field element into raw bytes in its internal Montgomery representation, | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 358 | /// Writes a field element into raw bytes in its internal Montgomery representation, | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:356:9 | 356 | /// `PrimeField` implementation. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 356 | /// `PrimeField` implementation. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:355:9 | 355 | /// Writes a field element in standard form, with endianness specified by the | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 355 | /// Writes a field element in standard form, with endianness specified by the | ++

warning: accessing first element with `self .selectors.get(0)` --> halo2_proofs/src/plonk.rs:207:20 | 207 | * (self | ____________________^ 208 | | .selectors 209 | | .get(0) | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `-W clippy::get-first` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::get_first)]` help: try | 207 ~ * (self 208 + .selectors.first() |

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:107:9 | 107 | /// does not perform any checks | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 107 | /// does not perform any checks | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:105:9 | 105 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 105 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:103:9 | 103 | /// `PrimeField` implementation, and checks that the element is less than the modulus. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 103 | /// `PrimeField` implementation, and checks that the element is less than the modulus. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:102:9 | 102 | /// Reads a field element in standard form, with endianness specified by the | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 102 | /// Reads a field element in standard form, with endianness specified by the | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:73:9 | 73 | /// WITHOUT performing the expensive Montgomery reduction. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 73 | /// WITHOUT performing the expensive Montgomery reduction. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:72:9 | 72 | /// Writes a field element into raw bytes in its internal Montgomery representation, | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 72 | /// Writes a field element into raw bytes in its internal Montgomery representation, | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:70:9 | 70 | /// `PrimeField` implementation. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 70 | /// `PrimeField` implementation. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk.rs:69:9 | 69 | /// Writes a field element in standard form, with endianness specified by the | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 69 | /// Writes a field element in standard form, with endianness specified by the | ++

warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/prover.rs:342:42 | 342 | .map(|_| Blind(F::random(&mut self.rng))) | ^^^^^^^^^^^^^ help: change this to: `self.rng` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits --> halo2_proofs/src/plonk/prover.rs:336:39 | 336 | *cell = F::random(&mut self.rng); | ^^^^^^^^^^^^^ help: change this to: `self.rng` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-W clippy::needless-borrows-for-generic-args` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrows_for_generic_args)]`

warning: doc list item without indentation --> halo2_proofs/src/plonk/lookup/prover.rs:566:5 | 566 | /// This method returns (A', S') if no errors are encountered. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 566 | /// This method returns (A', S') if no errors are encountered. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk/lookup/prover.rs:402:5 | 402 | /// This method returns (A', S') if no errors are encountered. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 402 | /// This method returns (A', S') if no errors are encountered. | ++

warning: doc list item without indentation --> halo2_proofs/src/plonk/lookup/prover.rs:73:9 | 73 | /// The Permuted<C> struct is used to update the Lookup, and is then returned. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `-W clippy::doc-lazy-continuation` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::doc_lazy_continuation)]` help: indent this line | 73 | /// The Permuted<C> struct is used to update the Lookup, and is then returned. | ++

warning: struct `PointIndex` is never constructed --> halo2_proofs/src/plonk/circuit.rs:1422:19 | 1422 | pub(crate) struct PointIndex(pub usize); | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/dev.rs:715:15 | 715 | #[cfg(feature = "thread-safe-region")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: lint `clippy::vtable_address_comparisons` has been renamed to `ambiguous_wide_pointer_comparisons` --> halo2_proofs/src/poly/query.rs:112:14 | 112 | #![allow(clippy::vtable_address_comparisons)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `ambiguous_wide_pointer_comparisons` | = note: `#[warn(renamed_and_removed_lints)]` on by default

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/plonk/permutation/keygen.rs:171:7 | 171 | #[cfg(feature = "thread-safe-region")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/plonk/permutation/keygen.rs:153:7 | 153 | #[cfg(feature = "thread-safe-region")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/plonk/permutation/keygen.rs:34:11 | 34 | #[cfg(not(feature = "thread-safe-region"))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/plonk/permutation/keygen.rs:20:11 | 20 | #[cfg(not(feature = "thread-safe-region"))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/plonk/permutation/keygen.rs:17:7 | 17 | #[cfg(feature = "thread-safe-region")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unused import: `Scope` --> halo2_proofs/src/multicore.rs:12:18 | 12 | join, scope, Scope, | ^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/circuit/layouter.rs:24:11 | 24 | #[cfg(not(feature = "thread-safe-region"))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/circuit/layouter.rs:21:11 | 21 | #[cfg(not(feature = "thread-safe-region"))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/circuit/layouter.rs:17:7 | 17 | #[cfg(feature = "thread-safe-region")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/circuit/layouter.rs:14:7 | 14 | #[cfg(feature = "thread-safe-region")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/dev.rs:715:15 | 715 | #[cfg(feature = "thread-safe-region")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: lint `clippy::vtable_address_comparisons` has been renamed to `ambiguous_wide_pointer_comparisons` --> halo2_proofs/src/poly/query.rs:112:14 | 112 | #![allow(clippy::vtable_address_comparisons)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `ambiguous_wide_pointer_comparisons` | = note: `#[warn(renamed_and_removed_lints)]` on by default

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/plonk/permutation/keygen.rs:171:7 | 171 | #[cfg(feature = "thread-safe-region")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/plonk/permutation/keygen.rs:153:7 | 153 | #[cfg(feature = "thread-safe-region")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/plonk/permutation/keygen.rs:34:11 | 34 | #[cfg(not(feature = "thread-safe-region"))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/plonk/permutation/keygen.rs:20:11 | 20 | #[cfg(not(feature = "thread-safe-region"))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/plonk/permutation/keygen.rs:17:7 | 17 | #[cfg(feature = "thread-safe-region")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unused import: `Scope` --> halo2_proofs/src/multicore.rs:12:18 | 12 | join, scope, Scope, | ^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/circuit/layouter.rs:24:11 | 24 | #[cfg(not(feature = "thread-safe-region"))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/circuit/layouter.rs:21:11 | 21 | #[cfg(not(feature = "thread-safe-region"))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

warning: unexpected `cfg` condition value: `thread-safe-region` --> halo2_proofs/src/circuit/layouter.rs:17:7 | 17 | #[cfg(feature = "thread-safe-region")] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `asm`, `backtrace`, `batch`, `circuit-params`, `default`, `dev-graph`, `gadget-traces`, `halo2_legacy_pdqsort`, `multicore`, `plotters`, `profile`, `sanity-checks`, `tabbycat`, and `test-dev-graph` = help: consider adding `thread-safe-region` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration