Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: crosschain integration #23

Merged
merged 16 commits into from
Jul 17, 2024
Merged

feat: crosschain integration #23

merged 16 commits into from
Jul 17, 2024

Conversation

yi-sun
Copy link
Contributor

@yi-sun yi-sun commented May 20, 2024

No description provided.

@yi-sun yi-sun changed the title wip: crosschain integration hold: crosschain integration May 20, 2024
@yi-sun yi-sun requested a review from ytham May 20, 2024 23:57
@yi-sun yi-sun marked this pull request as ready for review May 20, 2024 23:57
ytham
ytham requested changes May 21, 2024
View reviewed changes
cli/prove.ts Show resolved Hide resolved
cli/prove.ts Show resolved Hide resolved
src/AxiomTest.sol Show resolved Hide resolved
src/AxiomTest.sol Show resolved Hide resolved
src/AxiomV2Addresses.sol Outdated Show resolved Hide resolved
src/AxiomV2Addresses.sol Outdated Show resolved Hide resolved
@yi-sun yi-sun requested a review from ytham May 22, 2024 14:55
@yi-sun
Copy link
Contributor Author

yi-sun commented May 22, 2024

@ytham -- ready for re-review

ytham
ytham reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@ytham ytham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few minor items as well as changes to some functions that requires the latest client v2.1.0-alpha.7 that was just published.

cli/axiom-std-cli.ts Outdated Show resolved Hide resolved
cli/prove.ts Outdated Show resolved Hide resolved
cli/prove.ts Outdated Show resolved Hide resolved
cli/prove.ts Outdated Show resolved Hide resolved
@ytham
Copy link
Contributor

ytham commented May 22, 2024

one thing to note is that the CLI is unfortunately changing once more for 2.1.0-alpha.8: --rpcUrl's shortcut -r is changing to -sr due to an unfortunate conflict in query-params requiredOption --refundAddress already having shortcut -r

@yi-sun
Copy link
Contributor Author

yi-sun commented May 22, 2024

one thing to note is that the CLI is unfortunately changing once more for 2.1.0-alpha.8: --rpcUrl's shortcut -r is changing to -sr due to an unfortunate conflict in query-params requiredOption --refundAddress already having shortcut -r

axiom-std doesn't call the CLI, so that should be fine.

ytham
ytham approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@ytham ytham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yi-sun and others added 3 commits May 28, 2024 17:04
@yi-sun
feat: enable usage of chains without pre-existing deployments in axio…
fb3a28d 
…m-std (#25)

* feat: enable usage of chains without pre-existing deployments in axiom-std

* chore: update axiom-client

* chore: update axiom-client

* chore: fix CI
@ytham
Fix crosschain run function (#27)
0950263
@yi-sun
chore: bump SDK version
ea4607d
@yi-sun yi-sun changed the title hold: crosschain integration feat: crosschain integration Jul 16, 2024
ytham
ytham approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@ytham ytham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yi-sun yi-sun merged commit b406ae6 into main Jul 17, 2024
4 checks passed
@yi-sun yi-sun deleted the feat/crosschain branch July 17, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytham ytham ytham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yi-sun @ytham