Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/cleanup #7

Merged
merged 13 commits into from
Feb 13, 2024
Merged

Chore/cleanup #7

merged 13 commits into from
Feb 13, 2024

Conversation

rpalakkal
Copy link
Contributor

closes #3 and #4

jonathanpwang
jonathanpwang reviewed Feb 8, 2024
View reviewed changes
circuit/src/types.rs Outdated Show resolved Hide resolved
jonathanpwang
jonathanpwang approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from nits

@rpalakkal rpalakkal merged commit e3b34e0 into main Feb 13, 2024
1 check passed
@rpalakkal rpalakkal deleted the chore/cleanup branch February 13, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename crates
2 participants
@rpalakkal @jonathanpwang