Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --to-stdout flag to feat/axiom-std-2 #29

Merged
merged 4 commits into from
Jun 3, 2024
Merged

add --to-stdout flag to feat/axiom-std-2 #29

merged 4 commits into from
Jun 3, 2024

Conversation

ytham
Copy link
Contributor

@ytham ytham commented Jun 1, 2024

  • Adds --to-stdout flag to feat/axiom-std-2

@ytham ytham marked this pull request as ready for review June 2, 2024 01:55
@ytham ytham requested a review from yi-sun June 2, 2024 01:55
yi-sun
yi-sun approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@yi-sun yi-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is it possible to enable the --to-stdout flag for witness-gen only? Not an issue if it's cumbersome to do that.

@ytham
Copy link
Contributor Author

ytham commented Jun 3, 2024

@yi-sun ready for re-review

yi-sun
yi-sun approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@yi-sun yi-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yi-sun yi-sun merged commit fe76d66 into feat/axiom-std-2 Jun 3, 2024
1 check passed
@yi-sun yi-sun deleted the feat/axiom-std-2-stdout branch June 3, 2024 07:09
yi-sun added a commit that referenced this pull request Jun 4, 2024
@yi-sun @ytham
feat: new commands for axiom-std support (#28)
0258cc5 
* feat: add witness gen CLI command

* add --to-stdout flag to feat/axiom-std-2 (#29)

* WIP: add to_stdout cli param

* stdout for all write fns

* Update  for witnessgen only

* Update readme

---------

Co-authored-by: Yu Jiang Tham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yi-sun yi-sun yi-sun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ytham @yi-sun